Update Firedrake installation instructions and workflow#125
Merged
Conversation
95ce222 to
270118f
Compare
joewallwork
requested changes
Apr 13, 2025
Member
joewallwork
left a comment
There was a problem hiding this comment.
This is great, thanks @ddundo. Just one request regarding Chaco.
Member
Author
joewallwork
approved these changes
Apr 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #112.
The Firedrake installation approach moved away from the
firedrake-installscript and is now clearly separated in three distinct steps that are described in https://www.firedrakeproject.org/install.html and that are very easy for users to follow. We follow their instructions almost exactly as described, except that we pass some extra flags to PETSc'sconfigure(--download-parmmgetc.).So here I removed a lot of our own installation instructions, as well as related files that we used to aid the installation process.