Minor Docker updates: drop Chaco and update build_docs.yml#126
Merged
Conversation
ddundo
force-pushed
the
minor-docker-updates
branch
from
7f368ab to
47c3c27
Compare
ddundo
changed the title
build_docs.yml
Member
Author
|
@jwallwork23 before I review your new PRs, would you mind reviewing this first please? Just so we have the CI running with the latest Docker image |
joewallwork
requested changes
Apr 16, 2025
Member
joewallwork
left a comment
joewallwork
left a comment
There was a problem hiding this comment.
Oh sorry @ddundo, I'd missed that this needed reviewing. I have a few requests.
ddundo
force-pushed
the
minor-docker-updates
branch
from
e06362f to
4e11039
Compare
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Member
Author
|
Thanks @jwallwork23 - I addressed your comments :) also added some I cancelled the docker build workflow since I made no further changes there. |
joewallwork
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Dockerfile.firedrake-parmmg(as discussed and done in Update Firedrake installation instructions and workflow #125)