Skip to content

Conversation

@jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Nov 10, 2025

This increases the dist/main.min.js size from 2217504 bytes to 2219470 bytes (an increase of 1966 bytes, or 0.09%).

See also RobotLocomotion/drake#23730.


This change is Reviewable

Copy link
Contributor Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, all discussions resolved


src/index.js line 20 at r1 (raw file):

import {LineMaterial} from 'three/examples/jsm/lines/LineMaterial.js';
import {LineGeometry} from 'three/examples/jsm/lines/LineGeometry.js';
import Stats from 'three/examples/jsm/libs/stats.module.js';

FYI https://stackoverflow.com/questions/36795819/when-should-i-use-curly-braces-for-es6-import

Also fix a warning in the rebuild Dockerfile.
@jwnimmer-tri
Copy link
Contributor Author

+assignee:@SeanCurtis-TRI for review, please.

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

@SeanCurtis-TRI reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jwnimmer-tri)

@jwnimmer-tri jwnimmer-tri merged commit f7b8588 into meshcat-dev:master Nov 10, 2025
@jwnimmer-tri jwnimmer-tri deleted the meshcat-stats-embed branch November 10, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants