Skip to content

feat: Unifying the Go library - #1

Merged
tfelix merged 1 commit into
mainfrom
feature/CU-86c9h60r6_Add-API-Key-support-for-TF-Runner
May 6, 2026
Merged

feat: Unifying the Go library#1
tfelix merged 1 commit into
mainfrom
feature/CU-86c9h60r6_Add-API-Key-support-for-TF-Runner

Conversation

@tfelix

@tfelix tfelix commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Unifies shared code between the runner and the run-controller to remove duplications and make maintenance easier.

CU-86c9h60r6

@tfelix
tfelix requested a review from malhussan May 4, 2026 15:59
@tfelix
tfelix force-pushed the feature/CU-86c9h60r6_Add-API-Key-support-for-TF-Runner branch 3 times, most recently from 0730005 to 4d4417a Compare May 5, 2026 11:00

@malhussan malhussan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've still not tested it myself, but I've got some remarks. I think we should run it somewhere against dev to continuously test it

Comment thread go-meshapi-client/go.mod Outdated
Comment thread go-meshapi-client/meshapi/dtos.go
Comment thread go-meshapi-client/meshapi/client.go Outdated
Comment thread go-meshapi-client/meshapi/dtos.go
Comment thread go-meshapi-client/meshapi/dtos.go
Comment thread run-controller/controller/runapi.go Outdated
Comment thread tf-block-runner/tfrun/runapi.go
Comment thread run-controller/Dockerfile
@tfelix
tfelix force-pushed the feature/CU-86c9h60r6_Add-API-Key-support-for-TF-Runner branch from 4d4417a to ea945ab Compare May 6, 2026 09:34
@tfelix
tfelix requested a review from malhussan May 6, 2026 09:34
Comment thread run-controller/Dockerfile
Comment thread run-controller/go.mod Outdated
Comment thread go.work.sum
@tfelix
tfelix force-pushed the feature/CU-86c9h60r6_Add-API-Key-support-for-TF-Runner branch from ea945ab to d4204cc Compare May 6, 2026 12:19
@tfelix
tfelix merged commit 6230510 into main May 6, 2026
2 checks passed
@Jelledb
Jelledb deleted the feature/CU-86c9h60r6_Add-API-Key-support-for-TF-Runner branch June 1, 2026 11:17
grubmeshi added a commit that referenced this pull request Jul 14, 2026
…type entry

Comparing against origin/main (the Kotlin baseline) showed the fail-vs-leave-as-is
change for misconfigured sensitive-input types already landed on this branch and
is already documented (docs/DEPRECATIONS.md, "Sensitive inputs of a non-STRING/
CODE/FILE type now fail the run"). T6 only shifts WHERE it fails (claim boundary),
so extend that entry rather than adding a duplicate.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants