Feed external hardware watchdog on Heltec Tower V2 (aka MeshTower V2) Implementation 2#2936
Merged
liamcottle merged 13 commits intoJul 13, 2026
Merged
Conversation
Merge dev branch
Address review comments
External watchdog support was added (but never merged) for MeshTower V1. The update's V2's #defines to follow the conventions set there and piggy back off the support already written for V1.
|
While @2904 has the description of why, this is the PR that should get merged. It creates a common framework for any node type with a hardware watchdog, and integrates it properly into the main loop. devteam, please use this PR. |
Contributor
|
here you go! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the same issue as #2904 and only one of these should be merged. If you haven't already, please read that PR's description first.
In the other fix, I simply started a
SoftwareTimerthat would feed the watchdog every 60 seconds. That was the smallest change I could make to fix the issue. I know the core devs are very busy, so I wanted to make the fix as small as possible.This PR contains a more comprehensive fix, but is also more code. It starts with the changes @Quency-D made in #1446 (which fixes the issue in MeshTower V1, but was never merged) and updates it to also fix the issue in MeshTower V2. In 1446, Quency added an API for feeding external watchdogs, and wired into the main loops of the different node types. With the correct
#defines, this same code works with MeshTower V2. I updated the#defines and added an instance ofExternalWatchdogManagerto the V2's variant.Testing
I flashed this to my device and verified the device hasn't rebooted.
If you'd like to test this yourself, here are build instructions for a repeater:
Head over to https://meshcore.io/flasher and use the "Custom firmware" option to flash
.pio/build/Heltec_tower_v2_repeater/firmware.zipHere's the compiled firmware for repeaters if you don't want to build it yourself: firmware.zip