ThinkNode M6/M1 room_server: set ROOM_PASSWORD default#2938
Merged
liamcottle merged 1 commit intoJul 13, 2026
Conversation
Without ROOM_PASSWORD the guest password defaults to empty, and a client sending a blank password is granted read+write access (can post). Every other board's room_server env sets ROOM_PASSWORD; the ThinkNode M6 and M1 were the only two shipping an open room. Default them to "hello" to match the rest of the tree; operators can still change it at runtime with 'set guest.password'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ThinkNode M6 and M1
room_serverenvs do not defineROOM_PASSWORD, so the guest password defaults to empty. A client that sends a blank password then matches and is granted read+write (post) access — i.e. the room ships open.Every other board that builds a room server (m3, t1000-e, rak_wismesh_tag, heltec_t114, …) sets
-D ROOM_PASSWORD='"hello"'; M6 and M1 were the only two omitting it. This adds the same default so a freshly flashed M6/M1 room is gated out of the box. Operators can still change it at runtime withset guest.password.No code changes; two
platformio.inilines.