Disable CAD on Companion Firmware until it's configurable - #3121
Merged
Conversation
recrof
self-requested a review
August 6, 2026 12:29
recrof
approved these changes
Aug 6, 2026
Member
|
Yes, CAD with the default settings does work really well in most environments but in some situations (noisy RF etc) CAD can cause transmit to hold off for the full 4 seconds almost every time you send a message which makes the node feel really slow and broken. The good news is that just adding the preamble IRQ already increased packet delivery rates from ~80% to ~93-95% in forced collision bench testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables the recently added CAD check in companion firmware that's done just before a transmit, until we have the ability to configure it for more widespread testing.
@oltaco has fixed a bug where IRQ flags were not configured correctly, which already drastically improves collision avoidance.
There's been a lot of internal discussion, as well as in some GitHub issues here and there that some of the CAD parameters need to be configured or tuned based on the RF environment.
So, to avoid any side effects of CAD being forced enabled on all companions, with no way to turn it off, we will leave it disabled for the v1.17.0 release, with the intention of adding a way to turn it on in a future firmware release.
The repeater firmware still requires users to enable CAD via
set cad on, and already defaults to off.