feat(cli): try confirm-or-revert prefs - #3358
Draft
benallfree wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft for visibility. Adds
try [reboot] <secs> <set-args>: apply a pref trial, persist it likeset, and auto-revert on RTC timeout unless the same key is committed withset. Up to 4 concurrent slots in/try.json(survives reboot). Optionalrebootreverts then reboots;set radio/set freqinherit reboot-on-revert.Upstream CommonCLI + role
loop()hooks only. No board variants, slim builds, or EnvyOS-specific radio/FEM work in this PR.Prior art / related
tempradio(mainline): temporary RF 4-tuple, live apply, not saved to prefs. #1910 (parser hardening only).hop.ignore(#2980): volatile RAM test knob, not persisted.trycovers anyset-able pref (pluspowersaving on|off): trial persisted, revert snapshot in/try.json, RTC timer, commit via matchingset.Sample commands
Test plan
try 10 radio.rxgain off→get try→ wait → reverts/try.jsonreload; timer still activetrythensetsame key commits and clears slottry 3600 radio …reboot armed on revertError: try slots full