Fix node-details remove action to preserve confirmation flow#5192
Merged
jamesarich merged 3 commits intomainfrom Apr 20, 2026
Merged
Fix node-details remove action to preserve confirmation flow#5192jamesarich merged 3 commits intomainfrom
jamesarich merged 3 commits intomainfrom
Conversation
8 tasks
Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Android/sessions/3944a0a8-4e30-400b-bdd4-d4c41695792b Co-authored-by: jamesarich <2199651+jamesarich@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bug removing node from individual node page
Fix node-details remove action to preserve confirmation flow
Apr 19, 2026
After the user taps Confirm on the remove-node dialog, the screen was left in a dead end showing ghost data. CommonGetNodeDetailsUseCase substitutes a fallback node rather than emitting null, so the UI had no signal to navigate away. Fix: thread an onAfterRemove callback through requestRemoveNode → handleNodeMenuAction → handleNodeAction, so onNavigateUp is invoked inside the onConfirm lambda immediately after removeNode() is launched. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a node works from the node list but fails from the individual node details screen. The details flow was navigating away immediately on remove, interrupting the confirmation/removal path.
Root cause
NodeMenuAction.Removein node details invokedonNavigateUp()immediately after dispatching the remove action.Code change
Regression coverage
HandleNodeActionTestinfeature:nodecommon tests to verify:NodeManagementActions.requestRemoveNode(...)Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:+UseParallelGC -XX:MaxMetaspaceSize=2g -XX:+HeapDumpOnOutOfMemoryError -Xmx8g -Dfile.encoding=UTF-8(dns block)If you need me to access, download, or install something from one of these locations, you can either: