[Bug]: Client notification for invalid radio config is sent too early

[Stary2001]

Category

BLE

Hardware

Seeed Card Tracker T1000-E

Is this bug report about any UI component firmware like InkHUD or Meshtatic UI (MUI)?

• Meshtastic UI aka MUI colorTFT
• InkHUD ePaper
• OLED slide UI on any display

Firmware Version

2.7.13.91162bdc2

Description

When setting an invalid radio preset (currently just ShortTurbo in the EU region), I don't get the phone notification.
Perhaps validation should be moved ahead of time and then the bad settings can be rejected early like is done for the serial/mqtt moduleconfig.

Relevant log output

INFO  | 20:19:21 12230 [Router] Received Admin from=0x0, id=0x8b20965e, portnum=6, payloadlen=39
INFO  | 20:19:21 12230 [Router] Handle admin payload 34
DEBUG | 20:19:21 12230 [Router] Client set config
INFO  | 20:19:21 12230 [Router] Set config: LoRa
INFO  | 20:19:21 12230 [Router] Disable NRF52 bluetooth
DEBUG | 20:19:21 12230 [Router] FromRadio=STATE_SEND_PACKETS
INFO  | 20:19:21 12230 [Router] BLE Disconnected, reason = 0x16
DEBUG | 20:19:21 12230 [Router] PhoneAPI::close()
DEBUG | 20:19:21 12230 [Router] BluetoothStatus DISCONNECTED
INFO  | 20:19:21 12230 [Router] Ended BLE connection
INFO  | 20:19:21 12230 [Router] Save changes to disk
DEBUG | 20:19:21 12230 [Router] Expand short PSK #1
INFO  | 20:19:21 12230 [Router] Wanted region 3, using EU_868
ERROR | 20:19:21 12230 [Router] Regional frequency range is smaller than bandwidth. Fall back to default preset
ERROR | 20:19:21 12230 [Router] NOTE! Record critical error 7 at src/mesh/RadioInterface.cpp:544
DEBUG | 20:19:21 12230 [Router] Send client notification to phone

[github-actions]

This issue has not had any comment or update in the last month. If it is still relevant, please post update comments. If no comments are made, this issue will be closed automagically in 7 days.

[github-actions]

This issue has not had any comment since the last notice. It has been closed automatically. If this is incorrect, or the issue becomes relevant again, please request that it is reopened.