Implement ATAK Plugin V2 and drop unishox2 compression support by thebentern · Pull Request #10105 · meshtastic/firmware

thebentern · 2026-04-08T18:37:57Z

Moves ATAK PLI traffic to ATAK_PLUGIN_V2 port using a flags-byte-prefixed TAKPacketV2 protobuf wire format, and removes all Unishox2 compression from the firmware path. Compression/decompression is now delegated entirely to client apps.

Changes

PositionModule: TAK tracker PLI now encodes to TAKPacketV2 protobuf on meshtastic_PortNum_ATAK_PLUGIN_V2. Payload wire format: [1 byte flags (0xFF = uncompressed sentinel)][raw TAKPacketV2 protobuf]. Includes correct ground_track → degrees×100 unit conversion and NUL-terminated callsign copies.
AtakPluginModule: Simplified to a pure SinglePortModule passthrough — no protobuf decode, no compression, no periodic OSThread scheduling. Removed OSThread inheritance, runOnce(), and all unused includes.
Unishox2: Removed unishox2.cpp / unishox2.h from the codebase entirely.

Wire format (ATAK_PLUGIN_V2)

[flags: 1 byte][payload: N bytes]
  flags = 0xFF  → payload is raw uncompressed TAKPacketV2 protobuf
  flags = 0x00–0x3F → bits 0-5 = zstd dictionary ID (app-originated, firmware passes through unchanged)

🤝 Attestations

I have tested that my proposed changes behave as described.
I have tested that my proposed changes do not cause any obvious regressions on the following devices:
- Heltec (Lora32) V3
- LilyGo T-Deck
- LilyGo T-Beam
- RAK WisBlock 4631
- Seeed Studio T-1000E tracker card
- Other (please specify below)

Copilot

Pull request overview

Implements ATAK Plugin V2 handling by moving ATAK payloads to the ATAK_PLUGIN_V2 port and removing Unishox2-based string compression from the firmware path.

Changes:

Switch TAK tracker PLI generation to TAKPacketV2 on meshtastic_PortNum_ATAK_PLUGIN_V2 with a flags-byte-prefixed wire payload.
Simplify AtakPluginModule into a SinglePortModule passthrough (no protobuf decode/alter/compression in firmware).
Remove Unishox2 compression implementation files from the codebase.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/modules/PositionModule.cpp	Generates ATAK V2 PLI packets and prefixes payload with a flags byte.
src/modules/AtakPluginModule.h	Refactors module to `SinglePortModule` and updates module documentation for V2 passthrough.
src/modules/AtakPluginModule.cpp	Removes legacy protobuf-based compression/decompression logic; keeps minimal passthrough handler.
src/mesh/compression/unishox2.h	Deletes Unishox2 public API header.
src/mesh/compression/unishox2.cpp	Deletes Unishox2 implementation.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…callsigns

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…tion source mapping

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…needs no periodic scheduling Agent-Logs-Url: https://github.com/meshtastic/firmware/sessions/bdc82eb6-77c4-4711-839c-04bcbb1aa9cd Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>

CLAassistant · 2026-04-08T20:15:34Z

All committers have signed the CLA.

Implement ATAK Plugin V2 and drop unishox2 compression support

7c1475c

thebentern requested a review from Copilot April 8, 2026 18:37

Merge branch 'develop' into tak_v2

17dbc2f

github-actions Bot added needs-review Needs human review enhancement New feature or request labels Apr 8, 2026

Copilot started reviewing on behalf of thebentern April 8, 2026 18:42 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Comment thread src/modules/PositionModule.cpp Outdated

Comment thread src/modules/PositionModule.cpp

Comment thread src/modules/PositionModule.cpp

Comment thread src/modules/PositionModule.cpp Outdated

Comment thread src/modules/PositionModule.cpp

Fix course calculation and improve error handling in allocAtakPli

10b9030

thebentern requested a review from Copilot April 8, 2026 19:03

Copilot started reviewing on behalf of thebentern April 8, 2026 19:04 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Comment thread src/modules/PositionModule.cpp

Comment thread src/modules/PositionModule.cpp

Comment thread src/modules/AtakPluginModule.cpp Outdated

Comment thread src/modules/AtakPluginModule.h

thebentern and others added 2 commits April 8, 2026 14:12

Update src/modules/AtakPluginModule.cpp

e8b757b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix buffer overflow in allocAtakPli by ensuring null termination for …

95bbb38

…callsigns

thebentern requested a review from Copilot April 8, 2026 19:23

Add missing include for concurrency::OSThread in AtakPluginModule.h

1b3537f

Copilot started reviewing on behalf of thebentern April 8, 2026 19:24 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Comment thread src/modules/PositionModule.cpp

Comment thread src/modules/PositionModule.cpp

Comment thread src/modules/AtakPluginModule.h Outdated

Comment thread src/modules/AtakPluginModule.cpp

Comment thread src/modules/AtakPluginModule.h

thebentern and others added 2 commits April 8, 2026 14:42

Update src/modules/AtakPluginModule.h

dd65bd2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Refactor allocAtakPli to use configurable team and role; improve posi…

94e22b3

…tion source mapping

thebentern requested a review from Copilot April 8, 2026 19:52

Copilot started reviewing on behalf of thebentern April 8, 2026 19:54 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Comment thread src/modules/PositionModule.cpp

Comment thread src/modules/PositionModule.cpp Outdated

Comment thread src/modules/AtakPluginModule.cpp Outdated

Update src/modules/PositionModule.cpp

a5afef1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of thebentern April 8, 2026 20:14 View session

Remove OSThread inheritance from AtakPluginModule - pure passthrough …

b2e8620

…needs no periodic scheduling Agent-Logs-Url: https://github.com/meshtastic/firmware/sessions/bdc82eb6-77c4-4711-839c-04bcbb1aa9cd Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>

Copilot finished work on behalf of thebentern April 8, 2026 20:16

Uh oh!

Conversation

thebentern commented Apr 8, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Wire format (ATAK_PLUGIN_V2)

🤝 Attestations

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CLAassistant commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thebentern commented Apr 8, 2026 •

edited by Copilot AI

Loading

CLAassistant commented Apr 8, 2026 •

edited

Loading