Test PR to remove LED_BUILTIN#10179
Merged
jp-bennett merged 2 commits intodevelopfrom Apr 16, 2026
Merged
Conversation
Comment out the LED_BUILTIN definition in platformio.ini
github-actions
Bot
added
needs-review
8 tasks
Collaborator
|
Interesting experiment. It looks like the LED_BUILTIN is only required in some nrf52 toolchain file (packages/framework-arduinoadafruitnrf52/libraries/InternalFileSytem/src/flash/flash_cache.c) and not for any esp32 devices. |
Collaborator
Author
|
@mverch67 yeah, looks like it. I'll wait for CI to fully complete, but this suggests an even cleaner solution, of adding the define in the nRF .in file. |
mverch67
approved these changes
Apr 16, 2026
jp-bennett
added a commit
that referenced
this pull request
Apr 17, 2026
jp-bennett
added a commit
that referenced
this pull request
Apr 17, 2026
thebentern
pushed a commit
that referenced
this pull request
Apr 21, 2026
* Test PR to remove LED_BUILTIN Comment out the LED_BUILTIN definition in platformio.ini * Add LED_BUILTIN definition to nrf52840.ini
thebentern
pushed a commit
that referenced
this pull request
Apr 21, 2026
mariotti
pushed a commit
to mariotti/firmware
that referenced
this pull request
May 6, 2026
* Test PR to remove LED_BUILTIN Comment out the LED_BUILTIN definition in platformio.ini * Add LED_BUILTIN definition to nrf52840.ini
mariotti
pushed a commit
to mariotti/firmware
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge, simply to demonstrate how many targets break without this define.