We have HardwareRNG, let's use it!#10274
Merged
jp-bennett merged 1 commit intomasterfrom Apr 23, 2026
Merged
Conversation
github-actions
Bot
added
needs-review
thebentern
approved these changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates nRF52 Bluetooth pairing to prefer HardwareRNG over random() when generating a non-fixed BLE PIN, aligning BLE security behavior with the new hardware-backed entropy facility.
Changes:
- Add
HardwareRNGinclude to the nRF52 Bluetooth implementation. - Generate random BLE passkeys using
HardwareRNG::fill()and map to a 6-digit PIN range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have the HardwareRNG feature, let's start preferring it over simple random() calls in places that make sense.
We might in the future even add a set of HardwareRNG::random() functions to make this even simpler.