fix: INA226 sensor detection#10365
Open
Krokodilushka wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes INA226 I2C detection in the device scanner so an INA226 at the shared INA/SHT2x address range is not subsequently misclassified as INA219, preventing incorrect sensor driver selection in telemetry.
Changes:
- Corrects the fallback conditional so “assume INA219” only runs when no INA226/INA260/SHT2x match has been detected.
Comment on lines
+447
to
+452
| if (detectSHT21SerialNumber(i2cBus, (uint8_t)addr.address)) { | ||
| logFoundDevice("SHTXX (SHT2X)", (uint8_t)addr.address); | ||
| type = SHTXX; | ||
| } else | ||
| #endif | ||
| else { // Assume INA219 if none of the above ones are found | ||
| logFoundDevice("INA219", (uint8_t)addr.address); | ||
| type = INA219; | ||
| { // Assume INA219 if none of the above ones are found |
Contributor
|
Note to self: check with #10482 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The firmware attempted to read data from an INA226 power sensor as if it were an INA219. Due to an incorrect conditional, any supported INA* sensor was incorrectly identified as an INA219.
Related logs:
Fix
Fixed the incorrect conditional used for sensor detection.
Hardware
ESP32-C6 + E22900M30S + INA226 + BMP580