Simplify tracking of BLE connection handle & improve thread safety.#10390
Open
cpatulea wants to merge 1 commit into
Open
Simplify tracking of BLE connection handle & improve thread safety.#10390cpatulea wants to merge 1 commit into
cpatulea wants to merge 1 commit into
Conversation
- Redefine isConnected in terms of nimbleBluetoothConnHandle. isConnected was not safe because BLEServer::getConnectedCount is not thread-safe (espressif/arduino-esp32#12538) while isConnected is called from various threads. Now we can avoid checking bleServer every time before calling isConnected. - getRssi: don't try to "populate nimbleBluetoothConnHandle", that requires calling BLEServer::getPeerDevices which is not thread-safe (same issue as above). The code simplifications are intended to facilitate merging of the pioarduino branch (meshtastic#9122), which makes many changes to NimBLE code.
Contributor
Author
|
This is a second pass at #10265 cc @compumike |
thebentern
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code simplifications are intended to facilitate merging of the pioarduino branch (#9122), which makes many changes to NimBLE code.
🤝 Attestations