Smart pointers and memory management cleanup

[thebentern]

No description provided.

[Copilot]

Pull request overview

This PR refactors several Portduino/platform and module components to use RAII/smart pointers instead of manual new/delete, and adds proper cleanup for the FreeRTOS concurrency::Lock semaphore handle.

Changes:

• Replace raw heap allocations with std::unique_ptr for safer ownership and automatic cleanup (PacketHistory, RotaryEncoderImpl, Portduino CH341 probe, Syslog formatting buffer).
• Introduce a free()-based deleter for StoreForward’s ps_calloc/calloc-allocated packet history buffer.
• Add a concurrency::Lock destructor to delete the underlying FreeRTOS semaphore.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/platform/portduino/PortduinoGlue.cpp	Use std::unique_ptr for CH341 probing to avoid manual delete paths.
src/modules/StoreForwardModule.h	Store packet history as unique_ptr with a free() deleter (matches calloc/ps_calloc).
src/modules/StoreForwardModule.cpp	Allocate packet history via reset() into the RAII-managed pointer.
src/mesh/PacketHistory.h	Replace raw PacketRecord* with std::unique_ptr<PacketRecord[]> and remove manual destructor.
src/mesh/PacketHistory.cpp	Update allocations/iteration to use unique_ptr::get() and rely on implicit cleanup.
src/input/RotaryEncoderImpl.h	Convert RotaryEncoder* to std::unique_ptr<RotaryEncoder>.
src/input/RotaryEncoderImpl.cpp	Remove manual delete logic; use unique_ptr::reset() for allocation.
src/DebugConfiguration.cpp	Use std::unique_ptr<char[]> for syslog formatting buffer (but see PR comment).
src/concurrency/Lock.h	Add destructor declaration.
src/concurrency/Lock.cpp	Implement FreeRTOS semaphore deletion in Lock::~Lock().

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.