Skip to content

Device detection#249

Merged
mkinney merged 5 commits intomeshtastic:masterfrom
mkinney:device_detection
Jan 30, 2022
Merged

Device detection#249
mkinney merged 5 commits intomeshtastic:masterfrom
mkinney:device_detection

Conversation

@mkinney
Copy link
Copy Markdown
Contributor

@mkinney mkinney commented Jan 30, 2022

a lot of research on what our devices report in various operating systems (mac, ubuntu, win10)

added a supported_device class and a collection of supported devices

now, we can see if the device(s) are on the supported list - needs more work like T-Echo and DIY

@vercel vercel bot temporarily deployed to Preview January 30, 2022 05:06 Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2022

Codecov Report

Merging #249 (72326d4) into master (069056e) will decrease coverage by 5.24%.
The diff coverage is 25.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   94.27%   89.02%   -5.25%     
==========================================
  Files          12       13       +1     
  Lines        1869     2023     +154     
==========================================
+ Hits         1762     1801      +39     
- Misses        107      222     +115     
Flag Coverage Δ
unittests 89.02% <25.32%> (-5.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
meshtastic/util.py 71.88% <6.45%> (-26.18%) ⬇️
meshtastic/supported_device.py 38.04% <38.04%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 069056e...72326d4. Read the comment docs.

@mkinney
Copy link
Copy Markdown
Contributor Author

mkinney commented Jan 30, 2022

Going to merge this PR and add tests later - want to use this code in the Meshtastic-flasher

@mkinney mkinney merged commit 3d77284 into meshtastic:master Jan 30, 2022
@mkinney mkinney deleted the device_detection branch February 3, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant