Fix changing modem_preset from CLI shortcuts#361
Merged
thebentern merged 1 commit intomeshtastic:masterfrom Aug 16, 2022
Merged
Fix changing modem_preset from CLI shortcuts#361thebentern merged 1 commit intomeshtastic:masterfrom
thebentern merged 1 commit intomeshtastic:masterfrom
Conversation
Previously the channel shortcuts (e.g. --ch-shortfast) would overrwrite the entire lora config, this meant you lost other configured things such as region. This patch changes that so that just modem_preset is overwritten, and also fixes the call to write config that was missing an argument.
Contributor
|
Nice! |
Member
|
One Hundered! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the channel shortcuts (e.g. --ch-shortfast) would overrwrite
the entire lora config, this meant you lost other configured things such
as region. This patch changes that so that just modem_preset is
overwritten, and also fixes the call to write config that was missing
an argument.