Skip to content

Conversation

@ianmcorvidae
Copy link
Contributor

Fixes #548

This makes it so null lat/lon/alt are just treated as 0s if present, but also makes it so lat & lon won't export nulls and alt won't export at all unless it's set.

@codecov
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 62.41%. Comparing base (bdf3a24) to head (4226201).

Files Patch % Lines
meshtastic/__main__.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
+ Coverage   62.39%   62.41%   +0.02%     
==========================================
  Files          14       14              
  Lines        2877     2879       +2     
==========================================
+ Hits         1795     1797       +2     
  Misses       1082     1082              
Flag Coverage Δ
unittests 62.41% <57.14%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae ianmcorvidae merged commit 9f0ba7a into meshtastic:master Apr 18, 2024
@ianmcorvidae ianmcorvidae deleted the export-import-config-altitude branch April 18, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: int() argument must be a string while importing settings

1 participant