Skip to content

Conversation

@ianmcorvidae
Copy link
Contributor

(at least assuming I didn't miss any)

@ianmcorvidae
Copy link
Contributor Author

I'll be merging this in a second assuming CI is happy (enough), which will also merge #551 and #552

@codecov
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 62.30%. Comparing base (70c5a30) to head (5ebc8e6).
Report is 1 commits behind head on master.

Files Patch % Lines
meshtastic/__main__.py 50.00% 8 Missing ⚠️
meshtastic/node.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
- Coverage   62.41%   62.30%   -0.12%     
==========================================
  Files          14       14              
  Lines        2879     2894      +15     
==========================================
+ Hits         1797     1803       +6     
- Misses       1082     1091       +9     
Flag Coverage Δ
unittests 62.30% <50.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae ianmcorvidae merged commit c529777 into meshtastic:master Apr 21, 2024
@ianmcorvidae ianmcorvidae deleted the more-dest-not-allowed branch April 21, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant