Skip to content

Enabled echo_response for all methods + serde(rename_all = "snake_case")#99

Merged
lukipuki merged 2 commits intomeshtastic:mainfrom
acelot:main
Apr 27, 2026
Merged

Enabled echo_response for all methods + serde(rename_all = "snake_case")#99
lukipuki merged 2 commits intomeshtastic:mainfrom
acelot:main

Conversation

@acelot
Copy link
Copy Markdown
Contributor

@acelot acelot commented Apr 23, 2026

Summary

  • echo_response: true for all stream_api methods
  • serde(rename_all = "snake_case")

Related Issues
No related issues.

Proposed Changes

  • Enabled echo_response for all stream_api methods. I don't know why it was disabled, it makes PacketRouter useless for methods like update_config, update_user, etc
  • Changed serde(rename_all = "camelCase") attribute to serde(rename_all = "snake_case") in build.rs. Same situation, I don't know why camelCase was used here. Protobuf protos are using snake_case field names, so I think we should use the same. This change will allow us to use static field names for referencing, for example using nameof crate.

Checklist

  • Tests pass locally (I've tested config saving)
  • Nothing to change in documentation

@acelot
Copy link
Copy Markdown
Contributor Author

acelot commented Apr 27, 2026

@lukipuki Hi, could you please review?

@lukipuki lukipuki merged commit 7425375 into meshtastic:main Apr 27, 2026
6 checks passed
@lukipuki
Copy link
Copy Markdown
Collaborator

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants