Enabled echo_response for all methods + serde(rename_all = "snake_case")#99
Merged
lukipuki merged 2 commits intomeshtastic:mainfrom Apr 27, 2026
Merged
Enabled echo_response for all methods + serde(rename_all = "snake_case")#99lukipuki merged 2 commits intomeshtastic:mainfrom
echo_response for all methods + serde(rename_all = "snake_case")#99lukipuki merged 2 commits intomeshtastic:mainfrom
Conversation
Contributor
Author
|
@lukipuki Hi, could you please review? |
lukipuki
approved these changes
Apr 27, 2026
Collaborator
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
echo_response: truefor all stream_api methodsserde(rename_all = "snake_case")Related Issues
No related issues.
Proposed Changes
echo_responsefor all stream_api methods. I don't know why it was disabled, it makes PacketRouter useless for methods likeupdate_config,update_user, etcserde(rename_all = "camelCase")attribute toserde(rename_all = "snake_case")inbuild.rs. Same situation, I don't know why camelCase was used here. Protobuf protos are using snake_case field names, so I think we should use the same. This change will allow us to use static field names for referencing, for example usingnameofcrate.Checklist