Bump REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL default value to300secs #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
…a-pytorch#1906) Summary: iiuc D84962784 correctly, v1 mesh does not rely on allocator heartbeat anymore. Yet we still get noises from its heartbeat timeout because the default value 5secs was set too aggressive for a large mesh. This diff bumps it to 300secs. Reviewed By: mariusae Differential Revision: D86678878
pzhan9
force-pushed
the
export-D86678878
branch
from
46fcd8b to
30d3e11
Compare
|
This pull request has been merged in a25c3ed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
iiuc D84962784 correctly, v1 mesh does not rely on allocator heartbeat anymore. Yet we still get noises from its heartbeat timeout because the default value 5secs was set too aggressive for a large mesh.
This diff bumps it to 300secs.
Reviewed By: mariusae
Differential Revision: D86678878