Skip to content

Bump REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL default value to300secs #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Bump REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL default value to300secs #1906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions hyperactor/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,12 +163,14 @@ declare_attrs! {
})
pub attr CLEANUP_TIMEOUT: Duration = Duration::from_secs(3);

/// Heartbeat interval for remote allocator
/// Heartbeat interval for remote allocator. We do not rely on this heartbeat
/// anymore in v1, and it should be removed after we finishing the v0
/// deprecation.
@meta(CONFIG = ConfigAttr {
env_name: Some("HYPERACTOR_REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL".to_string()),
py_name: None,
})
pub attr REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL: Duration = Duration::from_secs(5);
pub attr REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL: Duration = Duration::from_secs(300);

/// The default encoding to be used.
@meta(CONFIG = ConfigAttr {
Expand Down Expand Up @@ -315,7 +317,7 @@ mod tests {
assert_eq!(config[SPLIT_MAX_BUFFER_SIZE], 5);
assert_eq!(
config[REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL],
Duration::from_secs(5)
Duration::from_secs(300)
);
}

Expand Down Expand Up @@ -344,7 +346,7 @@ mod tests {
# export HYPERACTOR_CHANNEL_NET_RX_BUFFER_FULL_CHECK_INTERVAL=5s
# export HYPERACTOR_CHANNEL_MULTIPART=1
# export HYPERACTOR_DEFAULT_ENCODING=serde_multipart
# export HYPERACTOR_REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL=5s
# export HYPERACTOR_REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL=5m
# export HYPERACTOR_STOP_ACTOR_TIMEOUT=10s
# export HYPERACTOR_SPLIT_MAX_BUFFER_SIZE=5
# export HYPERACTOR_MESSAGE_TTL_DEFAULT=64
Expand Down