Make logs from spawn_exit_monitor part of ProcStatus
#1935
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 19, 2025
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
pzhan9
force-pushed
the
export-D87345385
branch
from
7aa43c4 to
6f1553e
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
pzhan9
force-pushed
the
export-D87345385
branch
from
6f1553e to
6805824
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
pzhan9
force-pushed
the
export-D87345385
branch
from
6805824 to
dde8104
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
|
This pull request has been merged in 59e8f9c. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Nov 20, 2025
…h#1935) Summary: Pull Request resolved: meta-pytorch#1935 As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385 fbshipit-source-id: ff9fbbdf43a5d153ecc4a412d51cedc7aac227cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As title.
This will be especially helpful when the process is forcefully killed by a signal, and the
Procdid not get a chance to log any exit status.Reviewed By: shayne-fletcher
Differential Revision: D87345385