Skip to content

Replace field mesh_name with host_mesh and proc_mesh #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Replace field mesh_name with host_mesh and proc_mesh #1937

wants to merge 3 commits into from

Conversation

@pzhan9
Copy link
Contributor

@pzhan9 pzhan9 commented Nov 19, 2025

Summary:
Right now I use mesh_name for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields.

This diff deprecates mesh_name, and add two new columns: proc_mesh and host_mesh.

Reviewed By: shayne-fletcher

Differential Revision: D87374168

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 19, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 19, 2025

@pzhan9 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87374168.

pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 19, 2025
@pzhan9 @facebook-github-bot
Replace field mesh_name with host_mesh and proc_mesh (meta-pytorch#1937)
d32e5d2 
Summary:

Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields.

This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`.

Reviewed By: shayne-fletcher

Differential Revision: D87374168
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
@pzhan9 @facebook-github-bot
Replace field mesh_name with host_mesh and proc_mesh (meta-pytorch#1937)
9a0d64f 
Summary:

Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields.

This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`.

Reviewed By: shayne-fletcher

Differential Revision: D87374168
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
@pzhan9 @facebook-github-bot
Replace field mesh_name with host_mesh and proc_mesh (meta-pytorch#1937)
4591c0e 
Summary:

Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields.

This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`.

Reviewed By: shayne-fletcher

Differential Revision: D87374168
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
@pzhan9 @facebook-github-bot
Replace field mesh_name with host_mesh and proc_mesh (meta-pytorch#1937)
3352684 
Summary:

Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields.

This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`.

Reviewed By: shayne-fletcher

Differential Revision: D87374168
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
@pzhan9 @facebook-github-bot
Replace field mesh_name with host_mesh and proc_mesh (meta-pytorch#1937)
50507a7 
Summary:

Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields.

This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`.

Reviewed By: shayne-fletcher

Differential Revision: D87374168
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
@pzhan9 @facebook-github-bot
Replace field mesh_name with host_mesh and proc_mesh (meta-pytorch#1937)
cd1ef02 
Summary:

Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields.

This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`.

Reviewed By: shayne-fletcher

Differential Revision: D87374168
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
@pzhan9 @facebook-github-bot
Replace field mesh_name with host_mesh and proc_mesh (meta-pytorch#1937)
e444e47 
Summary:

Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields.

This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`.

Reviewed By: shayne-fletcher

Differential Revision: D87374168
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
@pzhan9 @facebook-github-bot
Replace field mesh_name with host_mesh and proc_mesh (meta-pytorch#1937)
651c23d 
Summary:

Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields.

This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`.

Reviewed By: shayne-fletcher

Differential Revision: D87374168
@pzhan9 @facebook-github-bot
Make logs from spawn_exit_monitor part of ProcStatus (meta-pytorc…
dde8104 
…h#1935)

Summary:

As title.

This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status.

Reviewed By: shayne-fletcher

Differential Revision: D87345385
@pzhan9 @facebook-github-bot
Add event logs for HostMesh::shutdown and HostMesh::spawn (meta-pytor…
03eb4ff 
…ch#1936)

Summary:

As title.

Reviewed By: mariusae

Differential Revision: D87366183
@pzhan9 @facebook-github-bot
Replace field mesh_name with host_mesh and proc_mesh (meta-pytorch#1937)
ccda395 
Summary:

Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields.

This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`.

Reviewed By: shayne-fletcher

Differential Revision: D87374168
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
@pzhan9 @facebook-github-bot
Replace field mesh_name with host_mesh and proc_mesh (meta-pytorch#1937)
7f1274b 
Summary:

Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields.

This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`.

Reviewed By: shayne-fletcher

Differential Revision: D87374168
@meta-codesync meta-codesync bot closed this in 92b8eab Nov 20, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 20, 2025

This pull request has been merged in 92b8eab.

AlirezaShamsoshoara pushed a commit to AlirezaShamsoshoara/monarch that referenced this pull request Nov 20, 2025
@pzhan9 @AlirezaShamsoshoara
Replace field mesh_name with host_mesh and proc_mesh (meta-pytorch#1937)
d293115 
Summary:
Pull Request resolved: meta-pytorch#1937

Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields.

This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`.

Reviewed By: vidhyav, shayne-fletcher

Differential Revision: D87374168

fbshipit-source-id: fccb57ac7d022df2c9670a25fb89ef187bb77cee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pzhan9 @facebook-github-bot