-
Notifications
You must be signed in to change notification settings - Fork 109
Add events for ActorMesh #1938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Add events for ActorMesh #1938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 19, 2025
Summary: As title. Reviewed By: mariusae, vidhyav Differential Revision: D87382588
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
Summary: As title. Reviewed By: mariusae, vidhyav Differential Revision: D87382588
85990d0 to
49dc5a4
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
Summary: As title. Reviewed By: mariusae, vidhyav Differential Revision: D87382588
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
Summary: As title. Reviewed By: mariusae, vidhyav Differential Revision: D87382588
49dc5a4 to
f4d68bf
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
Summary: As title. Reviewed By: mariusae, vidhyav Differential Revision: D87382588
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
Summary: As title. Reviewed By: mariusae, vidhyav Differential Revision: D87382588
…h#1935) Summary: As title. This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status. Reviewed By: shayne-fletcher Differential Revision: D87345385
…ch#1936) Summary: As title. Reviewed By: mariusae Differential Revision: D87366183
Summary: Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields. This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`. Reviewed By: shayne-fletcher Differential Revision: D87374168
Summary: As title. Reviewed By: mariusae, vidhyav Differential Revision: D87382588
f4d68bf to
03e5d62
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Nov 20, 2025
Summary: As title. Reviewed By: mariusae, vidhyav Differential Revision: D87382588
|
This pull request has been merged in 028676b. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Nov 20, 2025
Summary: Pull Request resolved: meta-pytorch#1938 As title. Reviewed By: mariusae, vidhyav Differential Revision: D87382588 fbshipit-source-id: 8cf97b71f17c21f5546633ad3a2e7877893a60b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As title.
Reviewed By: mariusae, vidhyav
Differential Revision: D87382588