Skip to content

Conversation

@pzhan9
Copy link
Contributor

@pzhan9 pzhan9 commented Nov 19, 2025

Summary: As title.

Reviewed By: mariusae, vidhyav

Differential Revision: D87382588

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 19, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 19, 2025

@pzhan9 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87382588.

pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 19, 2025
Summary:

As title.

Reviewed By: mariusae, vidhyav

Differential Revision: D87382588
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
Summary:

As title.

Reviewed By: mariusae, vidhyav

Differential Revision: D87382588
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
Summary:

As title.

Reviewed By: mariusae, vidhyav

Differential Revision: D87382588
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
Summary:

As title.

Reviewed By: mariusae, vidhyav

Differential Revision: D87382588
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
Summary:

As title.

Reviewed By: mariusae, vidhyav

Differential Revision: D87382588
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
Summary:

As title.

Reviewed By: mariusae, vidhyav

Differential Revision: D87382588
…h#1935)

Summary:

As title.

This will be especially helpful when the process is forcefully killed by a signal, and the `Proc` did not get a chance to log any exit status.

Reviewed By: shayne-fletcher

Differential Revision: D87345385
…ch#1936)

Summary:

As title.

Reviewed By: mariusae

Differential Revision: D87366183
Summary:

Right now I use `mesh_name` for both proc and host mesh. I find it is not adequate, since for many logs, I could have both fields.

This diff deprecates `mesh_name`, and add two new columns: `proc_mesh` and `host_mesh`.

Reviewed By: shayne-fletcher

Differential Revision: D87374168
Summary:

As title.

Reviewed By: mariusae, vidhyav

Differential Revision: D87382588
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Nov 20, 2025
Summary:

As title.

Reviewed By: mariusae, vidhyav

Differential Revision: D87382588
@meta-codesync meta-codesync bot closed this in 028676b Nov 20, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 20, 2025

This pull request has been merged in 028676b.

AlirezaShamsoshoara pushed a commit to AlirezaShamsoshoara/monarch that referenced this pull request Nov 20, 2025
Summary:
Pull Request resolved: meta-pytorch#1938

As title.

Reviewed By: mariusae, vidhyav

Differential Revision: D87382588

fbshipit-source-id: 8cf97b71f17c21f5546633ad3a2e7877893a60b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants