Skip to content

rename fbgemm.permute_sparse_data to fbgemm.permute_2D_sparse_data #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

rename fbgemm.permute_sparse_data to fbgemm.permute_2D_sparse_data #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions torchrec/distributed/comm_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ def forward(
permuted_lengths_after_sparse_data_all2all,
sharded_input_embeddings,
_,
) = torch.ops.fbgemm.permute_sparse_data(
) = torch.ops.fbgemm.permute_2D_sparse_data(
forward_recat_tensor,
lengths_after_sparse_data_all2all.view(local_T * world_size, -1),
sharded_input_embeddings.view(-1),
Expand Down Expand Up @@ -676,7 +676,7 @@ def backward(ctx, *unused) -> Tuple[None, None, None, Tensor]:

if permuted_lengths_after_sparse_data_all2all is not None:
with record_function("## alltoall_seq_embedding_bwd_permute ##"):
_, sharded_grad_input, _ = torch.ops.fbgemm.permute_sparse_data(
_, sharded_grad_input, _ = torch.ops.fbgemm.permute_2D_sparse_data(
backward_recat_tensor,
permuted_lengths_after_sparse_data_all2all,
sharded_grad_input,
Expand Down
2 changes: 1 addition & 1 deletion torchrec/distributed/dist_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ def _wait_impl(self) -> KeyedJaggedTensor:

with record_function("## all2all_data:recat_values ##"):
if self._recat.numel():
lengths, values, weights = torch.ops.fbgemm.permute_sparse_data(
lengths, values, weights = torch.ops.fbgemm.permute_2D_sparse_data(
self._recat,
lengths.view(self._workers * self._splits[self._pg.rank()], -1),
values,
Expand Down
2 changes: 1 addition & 1 deletion torchrec/sparse/jagged_tensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,7 @@ def permute(
permuted_lengths,
permuted_values,
permuted_weights,
) = torch.ops.fbgemm.permute_sparse_data(
) = torch.ops.fbgemm.permute_2D_sparse_data(
indices_tensor,
self.lengths().view(len(self._keys), -1),
self.values(),
Expand Down