Use local anchor test action - #489
Merged
Merged
Conversation
Contributor
|
Repository Guard
Repository GuardCargo dependency pinning
Cross-program Anchor/Solana version consistency
solana-program crate pin
Anchor.toml solana_version
Crate minimum age
Yarn package.json pinning
npm minimum age
Workflow toolchain consistency
GitHub Action SHA pinning
Sensitive program / config changes
Overall status: pass Lockfile freshness (Cargo.lock + yarn.lock) is checked by the workflow directly and cannot be bypassed. The sensitive-diff section is a review hint - CODEOWNERS handles the actual merge gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
anchor-testjob caches./node_modules/under a constant key and then runs rootyarn. Since #488 made@metadaoproject/programsalink:./sdksymlink, re-linking over a cache saved with the old copy layout makes yarn delete files fromsdk/node_modulesthrough the symlink, failing withCannot find module '.../sdk/node_modules/superstruct/lib/index.cjs'. Any PR with a pre-#488 cache entry hits this after merging develop (#486, #481).The cache step lives inside
metadaoproject/anchor-test, so this copies the action (v2.3,876dde6) verbatim into.github/actions/anchor-test/and appendshashFiles('yarn.lock')to the cache key. Norestore-keys: a lockfile change means a clean install (~17s) instead of a re-link over a foreign tree. The workflow now uses the local action with the same inputs.Greptile Summary
This PR vendors the Anchor test composite action and makes the Node dependency cache sensitive to the root lockfile.
yarn.lockhash to thenode_modulescache key without fallback restore keys.Confidence Score: 5/5
The PR appears safe to merge, with no actionable behavioral, security, or repository-rule violations identified.
The cache key no longer matches pre-change caches, no restore prefix can reintroduce them, and the local action is invoked only after checkout while preserving the caller’s inputs.
Important Files Changed
Reviews (1): Last reviewed commit: "use local anchor test action" | Re-trigger Greptile