Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Destination to Public Dashboard URLs is broken on Static Embeds #38640

Closed
Tony-metabase opened this issue Feb 10, 2024 · 0 comments · Fixed by #38647
Closed

Custom Destination to Public Dashboard URLs is broken on Static Embeds #38640

Tony-metabase opened this issue Feb 10, 2024 · 0 comments · Fixed by #38647
Assignees
Labels
Embedding/Static Static embedding, previously known as signed embedding .Escalation .Needs Triage Priority:P2 Average run of the mill bug Sharing/Public .Team/Embedding Type:Bug Product defects
Milestone

Comments

@Tony-metabase
Copy link
Contributor

Tony-metabase commented Feb 10, 2024

Describe the bug

When you setup a Custom Destination to a public URL it breaks on static embeds with a Not Found when clicking on it.

To Reproduce

To Reproduce

  1. Turn on public sharing in admin settings
  2. Go to New -> Question -> Sample DB -> Orders -> Save as Question 1
  3. Go to New -> Question -> Sample DB -> Products -> Save as Question 2
  4. Go to New -> Dashboard -> Add Question 1 -> Save as Dashboard and make public
image
  1. Go to New -> Dashboard -> Add Question 2 -> Add Click Behaviour -> Save as Dashboard 2
    ---------------------------------------------> Click on Address
    ---------------------------------------------> Go to Custom Destination
    ---------------------------------------------> URL
    ---------------------------------------------> Paste Public URL for Dashboard 1
image
  1. Enable static Embedding for Dashboard 2 -> On the preview Panel Click on Address -> You will get a Not Found
image
  1. If you get the embed URL and paste the JWT link on the browser you will notice this:
image

Click on the Address Column and notice that the URL changes to the public one but you get a Not Found

image

Refreshing the browser works.

NOTE
Directly from Metabase -> Go to Dashboard 2 -> Click on Address -> Notice it works

Expected behavior

Public link to Dashbaord opens from Static Embedding

Logs

None that are relevant, even the Network Tab shows nothing only the image request

image

Information about your Metabase installation

Fails on 1.48.5 and master

Severity

This broke the functionality of a customer which used to work on 47 but upgrade to 48 broke this

Additional context

Since both logs and frontend logs (network and console) show nothing I am not sure if its a frontend or backend issue

@Tony-metabase Tony-metabase added Type:Bug Product defects Priority:P2 Average run of the mill bug .Needs Triage Embedding/Static Static embedding, previously known as signed embedding .Escalation Sharing/Public labels Feb 10, 2024
@WiNloSt WiNloSt self-assigned this Feb 12, 2024
@WiNloSt WiNloSt added this to the 0.48.6 milestone Feb 12, 2024
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embedding/Static Static embedding, previously known as signed embedding .Escalation .Needs Triage Priority:P2 Average run of the mill bug Sharing/Public .Team/Embedding Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants