Merged
Conversation
metabase-bot
bot
added
the
.Team/DashViz
alxnddr
force-pushed
the
indicate-in-progress-exports
branch
2 times, most recently
from
97ab936 to
ef0b788
Compare
alxnddr
added
the
backport
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 4a7d51a...ffc7f83.
|
|
alxnddr
force-pushed
the
indicate-in-progress-exports
branch
from
4ca4054 to
6c75447
Compare
EmmadUsmani
reviewed
Jul 25, 2024
frontend/src/metabase/status/hooks/use-check-active-downloads-before-unload.ts
Show resolved
Hide resolved
EmmadUsmani
approved these changes
Jul 29, 2024
alxnddr
force-pushed
the
indicate-in-progress-exports
branch
from
16f5c18 to
ffc7f83
Compare
alxnddr
added a commit
that referenced
this pull request
Jul 30, 2024
* indicate in-progress exports * specs, public dashboards * add onbeforeunload hook when uploads are in-progress
alxnddr
added a commit
that referenced
this pull request
Jul 31, 2024
* Indicate in-progress exports (#45697) * indicate in-progress exports * specs, public dashboards * add onbeforeunload hook when uploads are in-progress * fix resolving conflicts --------- Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I'm on vacation please merge the PR once it is approved
Closes #44686
Closes #41532
Description
Adds an in-progress indicator when users are exporting questions as CSV, JSON, or XLSX from the query builder or dashboards. We don't show it for PNG exports since they are essentially client-side and there is no meaningful delay.
It should be visible in all context: authenticated, public dashboards, embedded dashboards.
Even though this PR contains string changes we are still backporting it to v50
Slack thread on backporting
How to verify
Verify CSV, JSON, or XLSX downloads from query builder, dashboards including public and embedded show the loader.
Demo
Checklist