[equality] Comment out debugging statements in lib.quality/=

[alexander-yakushev]

Having these logging statements has significant impact on allocation rate, even if the requested logging level is disabled. That's because the logging system has to construct the logger object anyway.

I'd argue that having those logging statements always on isn't helpful because enabling debug log in that function would create immense noise because of how often this equality function is being called.

[edpaget]

Could we extend the log functions to avoid constructing the logger if we're not at the requested debug level?

[alexander-yakushev]

@edpaget The problem is that knowing if we are at the requested debug level for this particular process/namespace/file requires constructing a logger (or at least reading into the logging config). Maybe, it is somehow possible to make this check leaner, but it will still be an overhead which is quite redundant for a such heavily called function.

[camsaul]

Can you please add a note why you're commenting these out (for performance reasons)? Other than that it looks good to me.

[github-actions]

e2e tests failed on 5f41f94799762bb172e41555d04ea49a7c59dd1c-1

e2e test run

File	Test Name
source-replacement.cy.spec.ts	scenarios > data-studio > source replacement > Native queries > replaces a table referenced in a native SQL question
embed-parameters.cy.spec.ts	scenarios > embedding > sdk iframe embed setup > embed parameters > resources without parameters > shows no parameters message for dashboards without parameters
maps.cy.spec.js	scenarios > visualizations > maps > should preserve zoom and pan after resize (#11211)
query-external.cy.spec.js	scenarios > question > query > external > can query Mongo database