🤖 backported "Replace flaky e2e repro no. 55637 with predicate unit test"#73594
Merged
github-automation-metabase merged 1 commit intoMay 4, 2026
Conversation
Extract `infoPopoversDisabled` logic from TableInteractive into a pure helper and pin its four branches (including the `clicked !== null` clause that fixed issue no. 55637) with a unit test. Drop the e2e repro that was flagged by Trunk as one of the flakiest specs. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-automation-metabase
added
the
was-backported
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
e2e tests failed on
|
| File | Test Name |
|---|---|
metrics-explorer.cy.spec.ts |
scenarios > metrics > explorer > Adding metrics and measures > should add metrics and measures from the entity picker |
metrics-explorer.cy.spec.ts |
scenarios > metrics > explorer > Adding metrics and measures > should add multiple metrics one by one using metrics dropdown |
model-actions.cy.spec.js |
Write actions on model detail page (postgres) > should respect impersonated permission |
source-replacement.cy.spec.ts |
scenarios > data-studio > source replacement > Native queries > replaces a table referenced in a native SQL question |
metrics-explorer.cy.spec.ts |
scenarios > metrics > explorer > Expression custom names > should not change expression pill color when renaming |
metrics-explorer.cy.spec.ts |
scenarios > metrics > explorer > Expression custom names > should preserve custom name when the expression is edited in place but keeps at least one original metric |
tabs.cy.spec.js |
scenarios > dashboard > tabs > should only fetch cards on the current tab of an embedded dashboard |
embed-parameters.cy.spec.ts |
scenarios > embedding > sdk iframe embed setup > embed parameters > resources without parameters > shows no parameters message for dashboards without parameters |
metrics-explorer.cy.spec.ts |
scenarios > metrics > explorer > metric math > should handle metrics with numeric names in expressions |
data-studio-bulk-table.cy.spec.ts |
bulk table operations > allows to edit attributes for db |
github-automation-metabase
merged commit fbddf2b
into
release-x.61.x
194 of 199 checks passed
github-automation-metabase
deleted the
backport-61-0b2c1965f95524e1b274710601d30e86e8afbda5
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#73556