Skip to content

Fix filter not respected when downloading visualizer-affected card from dashboard#75720

Merged
andsalves merged 1 commit into
masterfrom
fix/71638-dashboard-combo-series-download-filters
Jun 11, 2026
Merged

Fix filter not respected when downloading visualizer-affected card from dashboard#75720
andsalves merged 1 commit into
masterfrom
fix/71638-dashboard-combo-series-download-filters

Conversation

@andsalves

@andsalves andsalves commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Closes #71638

Description

Fixes dashboard XLSX downloads for multi-source visualizer dashcards so applied dashboard filters are preserved in the download request.

The dashboard-card export endpoint already accepts parameters, but visualizer dashcards were passing transformed series data into the download menu. For combo visualizer cards, that data can omit json_query.parameters, causing downloads to send parameters=[]. This change uses the stored primary card dataset from dashcardData when available, falling back to the previous series result otherwise.

How to verify

  1. Create a dashboard with a multi-source visualizer line chart.
  • For the example I used, I created a question against Analytics Events → Count by Timestamp, and the second question was just the same but with a filter (Active Subscripion=true)
image 2. Add a dashboard date filter mapped to the source cards. 3. Apply the date filter. 4. Download the visualizer dashcard results as `.xlsx`. 5. Confirm the XLSX data respects the applied dashboard filter.

Demo

https://www.loom.com/share/96bb25e1b6544cf291a09afade20653a

Checklist

  • Tests have been added/updated to cover changes in this PR
  • If adding new Loki tests: they pass stress testing

@metabase-bot metabase-bot Bot added the .Team/UXWest UX West - use for bugs and feature requests label Jun 11, 2026
@andsalves andsalves added the backport Automatically create PR on supported major release branches on merge label Jun 11, 2026
@andsalves andsalves changed the title Fix filtered dashboard card xlsx downloads Fix filter not respected when downloading visualizer-affected card from dashboard Jun 11, 2026
@andsalves andsalves marked this pull request as ready for review June 11, 2026 16:47
@andsalves andsalves requested a review from a team June 11, 2026 16:47
@andsalves andsalves merged commit daef670 into master Jun 11, 2026
547 of 554 checks passed
@andsalves andsalves deleted the fix/71638-dashboard-combo-series-download-filters branch June 11, 2026 19:02
@github-actions

Copy link
Copy Markdown
Contributor

@andsalves Manual conflict resolution is required on #75743

@github-actions

Copy link
Copy Markdown
Contributor

@andsalves Manual conflict resolution is required on #75747

github-automation-metabase added a commit that referenced this pull request Jun 11, 2026
…fected card from dashboard" (#75744)

Fix filter not respected when downloading visualizer-affected card from dashboard (#75720)

Fix filtered dashboard card xlsx downloads

Co-authored-by: Anderson <ands.alves.nunes@gmail.com>
github-automation-metabase added a commit that referenced this pull request Jun 11, 2026
…fected card from dashboard" (#75746)

Fix filter not respected when downloading visualizer-affected card from dashboard (#75720)

Fix filtered dashboard card xlsx downloads

Co-authored-by: Anderson <ands.alves.nunes@gmail.com>
github-automation-metabase added a commit that referenced this pull request Jun 11, 2026
…fected card from dashboard" (#75745)

Fix filter not respected when downloading visualizer-affected card from dashboard (#75720)

Fix filtered dashboard card xlsx downloads

Co-authored-by: Anderson <ands.alves.nunes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Automatically create PR on supported major release branches on merge .Team/UXWest UX West - use for bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter not respected when downloading visualizer-affected card from dashboard

2 participants