Skip to content

Do not use absolute URLs in illustrations#7601

Merged
salsakran merged 1 commit intometabase:masterfrom
hjalves:master
May 14, 2018
Merged

Do not use absolute URLs in illustrations#7601
salsakran merged 1 commit intometabase:masterfrom
hjalves:master

Conversation

@hjalves
Copy link
Copy Markdown
Contributor

@hjalves hjalves commented May 10, 2018

This fixes #6704.
Works in both non-root app context and root app contexts.

Before submitting the PR, please make sure you do the following
  • If there are changes to the backend codebase, run the backend tests with lein test && lein eastwood && lein bikeshed && lein docstring-checker && ./bin/reflection-linter
  • Run the frontend and integration tests with yarn lint && yarn flow && yarn test)
  • Sign the Contributor License Agreement
    (unless it's a tiny documentation change).

@salsakran salsakran requested review from kdoh and tlrobinson May 10, 2018 00:27
@tlrobinson
Copy link
Copy Markdown
Contributor

Thanks for doing this. Looks like there's a few others if you feel like handling those, otherwise we can do another PR:

$ grep -r 'image="/' frontend
frontend/src/metabase/containers/EntitySearch.jsx:                  image="/app/img/empty_question"
frontend/src/metabase/dashboards/containers/Dashboards.jsx:              image="/app/img/dashboard_illustration"
frontend/src/metabase/dashboards/containers/Dashboards.jsx:                  image="/app/img/empty_dashboard"
frontend/src/metabase/dashboards/containers/DashboardsArchive.jsx:                  image="/app/img/empty_dashboard"
frontend/src/metabase/new_query/containers/MetricSearch.jsx:                  image="/app/img/metrics_illustration"
frontend/src/metabase/new_query/containers/NewQueryOptions.jsx:                    image="/app/img/questions_illustration"
frontend/src/metabase/new_query/containers/NewQueryOptions.jsx:                  image="/app/img/query_builder_illustration"
frontend/src/metabase/new_query/containers/NewQueryOptions.jsx:                    image="/app/img/sql_illustration"
frontend/src/metabase/questions/containers/QuestionIndex.jsx:      image="/app/img/questions_illustration"

@hjalves
Copy link
Copy Markdown
Contributor Author

hjalves commented May 10, 2018

Ok, I will update this MR with those changes after making some tests

@hjalves hjalves changed the title Do not use absolute URLs in illustrations in New Question page Do not use absolute URLs in illustrations May 10, 2018
@hjalves
Copy link
Copy Markdown
Contributor Author

hjalves commented May 10, 2018

Tested every page where those illustrations appear. Both with non-root and root URL's.

Copy link
Copy Markdown
Member

@kdoh kdoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hjalves!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Illustration images not found when run with non-root app context

5 participants