Do not use absolute URLs in illustrations#7601
Merged
salsakran merged 1 commit intometabase:masterfrom May 14, 2018
Merged
Conversation
Contributor
|
Thanks for doing this. Looks like there's a few others if you feel like handling those, otherwise we can do another PR: |
tlrobinson
approved these changes
May 10, 2018
Contributor
Author
|
Ok, I will update this MR with those changes after making some tests |
Contributor
Author
|
Tested every page where those illustrations appear. Both with non-root and root URL's. |
kdoh
approved these changes
May 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #6704.
Works in both non-root app context and root app contexts.
Before submitting the PR, please make sure you do the following
lein test && lein eastwood && lein bikeshed && lein docstring-checker && ./bin/reflection-linteryarn lint && yarn flow && yarn test)(unless it's a tiny documentation change).