Mingw/msys2 support - #846
Conversation
|
@yug105 respect to this code: I have removed it, you must go to the backtrace plugin, I am going to add that code but in theory it seems that it supports the backtrace one: What was the error you were getting? Edit: Here is how to do it: |
|
I also have removed this: It's not the proper way of doing it. What error were you getting with this? Respect to the delay load mechanism, it's documented on metacall/plthook-poc, I can write the function to reuse it automatically for you, so we can add this to all cases where we need the delay load mechanism. But the delay load mechanism is only required in loaders, the fork should not need it. Fork safety mechanism works on MSVC. |
| else | ||
| # Tests (coverage needs to run the tests) | ||
| if [ $BUILD_TESTS = 1 ] || [ $BUILD_BENCHMARKS = 1 ] || [ $BUILD_COVERAGE = 1 ]; then | ||
| ctest -j$(getconf _NPROCESSORS_ONLN) --timeout 5400 --output-on-failure --test-output-size-failed 3221000000 -C $BUILD_TYPE |
There was a problem hiding this comment.
Is there any reason for this change?
There was a problem hiding this comment.
Yes, actually this error was coming Invalid value for '--test-output-size-failed': 3221000000 so i changed it to 2147483647 (INT_MAX) to make it valid on windows
The error occurred on MinGW:
I temporarily disabled |
this is the error i got, thanks for the link i think it will get away with the link error we are getting. |
| endif() | ||
|
|
||
| if(MINGW) | ||
| add_compile_definitions(__MSVCRT_VERSION__=0x900) |
There was a problem hiding this comment.
you can make this per target instead of per project
Adds MinGW/MSYS2 support for Windows. A new CI workflow builds and tests on
mingw64,mingw32,ucrt64, andclang64using thetools/metacall-*.shscripts. All four environments pass 100% of the tests.Changes:
syslog: Fixed theReportEventconst pointer type.metacall_link: AddedWINAPIto the trampoline typedef to fix a calling-convention mismatch on 32-bit Windows.pid_twith_MSC_VER, as MinGW already defines it.dbghelpforplthook_detourand skipped-rdynamicon Windows.Disabled on MinGW because they are not currently supported:
backward-cppfails to build with GCC and deadlocks during loading with Clang.