Add admin status to nic port#655
Merged
Merged
Conversation
metal-robot
Bot
added
the
area: control-plane
iljarotar
marked this pull request as draft
June 30, 2026 10:53
2 tasks
iljarotar
marked this pull request as ready for review
July 3, 2026 14:52
iljarotar
marked this pull request as draft
July 3, 2026 14:53
There was a problem hiding this comment.
Pull request overview
This PR introduces an explicit administrative (desired) port status for switch NICs to avoid the current overloading of Actual, which can lead to metal-core incorrectly driving ports to DOWN. It also relaxes port-toggling behavior so ports without an attached machine can still be administratively enabled/disabled.
Changes:
- Add
admin_statusto the switch NIC API model/spec to represent desired port state separately fromactual. - Allow toggling a switch port even when no machine is connected to that NIC.
- Adjust
NicStatedesired/actual semantics and update related unit tests.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/metal-api.json | Adds admin_status to the OpenAPI schema for switch NICs (currently marked as required). |
| cmd/metal-api/internal/testdata/testdata.go | Updates test fixtures for switch/machine connection scenarios. |
| cmd/metal-api/internal/service/v1/switch.go | Adds AdminStatus field to the v1 SwitchNic API type. |
| cmd/metal-api/internal/service/switch-service.go | Updates switch port toggle behavior and response mapping for admin_status. |
| cmd/metal-api/internal/service/switch-service_test.go | Updates toggle-port tests to validate AdminStatus behavior and new 200 OK behavior for unconnected NICs. |
| cmd/metal-api/internal/metal/network.go | Simplifies NicState state transitions to preserve Desired across SetState. |
| cmd/metal-api/internal/metal/network_test.go | Updates unit tests to match new NicState transition semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| r.sendError(request, response, httperrors.BadRequest(err)) | ||
| return | ||
| } | ||
| r.log.Debug("toggle switch port", "request", requestPayload) |
Contributor
|
LGTM, as it is much easier to store let's hope it works :-) |
mwennrich
approved these changes
Jul 15, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ulrichSchreiner
approved these changes
Jul 15, 2026
iljarotar
marked this pull request as ready for review
July 15, 2026 12:46
Contributor
|
This must be retrofitted into metal-apiserver an apiv2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The double-role of the
Actualfield of a switch port causes a bug in the metal-core that sometimes results in ports being set to DOWN by metal-core (metal-stack/metal-core#196).A cleaner solution would include adding a table for the switch status and remove all status fields from the switch table. Then the reports coming from metal-core will only be reflected in the switch status table while the switch table would only hold the desired state of a switch. Once metal-core is migrated to v2API, we should work on this cleaner solution. For now, this quick solution is okay, I think.
TODO