Allow the user to pick read-only or read-write locking#32
Merged
Conversation
HaoZeke
reviewed
May 7, 2026
|
|
||
| let mut data = std::ptr::null_mut(); | ||
| ctx.with_lock_mut(|lock| { | ||
| // Cast mut is fine, we set the read-only flag in the DLPack tensor |
Member
There was a problem hiding this comment.
Should this include // SAFETY: Promises to honor DLPack flag
HaoZeke
approved these changes
May 7, 2026
HaoZeke
left a comment
HaoZeke
left a comment
Member
There was a problem hiding this comment.
LGTM. Just a very minor nit. Later we might want to have an error return instead of expect() on the lock stuff, but not now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to enable Rust code to create and modify arrays, and then only hand out read-only references through
as_dlpack()This can be controlled by passing either
ReadOnly<...>orReadWrite<...>totry_into