Tests: jquery + native DOM backends by jankapunkt · Pull Request #497 · meteor/blaze

jankapunkt · 2026-03-31T08:32:44Z

This is a follow up on #493 which adjusts the tests to be compatible with and without jQuery.

remove all direct jQuery dependencies in Blaze packages
remove jquery dependencies in test-in-browser (attention, this is a core package)
pass all tests with jQuery
pass all tests without jQuery
fix Teardown for native DOM backend
fix event delegation for native DOM backend
adapt CI to run testsuite with both setups in sequence (first using native, then jQuery)

Findings form initial research

📢 Update: all of the issues below were addressed in this PR, see comments further below

1. tests satisfaction
This PR focused only on passing tests when DOM backend is native AND if jQuery is used.

2. jQuery in tests
Many tests used jquery by default, for example to find or remove elements:

$(div).remove()

This causes the native DOM backend to fail, because there is no native communication between the removal and the Teardown (which removes reactive listeners etc.).
As a solution, the native HTMLElement.prototype.remove method gets overridden to call the teardown for the element and its children.
This needs to be tested appropriately using apps.

3. template scoped events
With jQuery, events are automatically scoped to the template level. This prevents event selector in a child template to bubble up the event to the parent template, if the selector matches.
As a solution, the parent chain is traversed upwards to see if a view is associated and if it changed, once the selector does not match the current element anymore.
This needs to be tested appropriately using apps.

4. external dependencies
The weak dependency of jQuery automatically loads, once any other package has loaded jQuery. However, the test-in-browser (peer-dep of Tinytest via tinytest-harness) causes jQuery to be included in any case.
This is therefore on hold, until test-in-browser has jQuery removed.

Once this is done, we can leverage an env variable to include jQuery in tests, without adding it as a dependency and adjust CI to run tests with jQuery and with native DOM backend.

…ses, fn)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.18.1. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.18.1) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.18.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ests

… tests

jankapunkt · 2026-04-08T07:55:06Z

The local browser tests, as well as CI, are now fully compatible with adding or removing jquery in a reproducible way.

jquery is now a weak dependency on blaze package, which holds the dombackend
by default, no packages in the package bundle contains jquery, causing the default test suite to run using the native DOMBackend
the modified test-in-browser package has no jquery dependency anymore and is for now added as a local package (test-only) to this repository until packages: remove jQuery from test-in-browser meteor#14308 is fully resolved.
the test suite runs some extra tests in jquery mode, that are only related to jquery behavior
no modification for test-in-console needed

Run dual mode in local browser tests:

First, cd to test-app and install npm deps, then

no jquery

meteor npm run test:watch # runs 412 tests

qith jquery

meteor npm run test:jquery # runs 416 tests

Run dual mode in `test-in-console`

As the CI uses test-in-console by default the native DOM backend is used. If jquery should be used, add --extra-packages=jquery to the test command.

Copilot

Pull request overview

This PR updates Meteor/Blaze’s test infrastructure and several package test suites to run cleanly in both DOM backends: with jQuery present (legacy behavior) and without jQuery (native DOM backend).

Changes:

Adds a jQuery-free test-in-browser driver/package and updates CI to run the test suite both with and without --extra-packages=jquery.
Refactors Blaze/Spacebars/Observe-sequence tests to avoid direct jQuery usage and to tolerate either backend.
Updates Blaze’s DOM backend implementation for native event delegation + teardown behavior, and bumps the test app Meteor release/deps.

Reviewed changes

Copilot reviewed 25 out of 28 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
test-app/package.json	Removes npm jQuery dep; adds `test:jquery` script; bumps dependencies.
test-app/.meteor/versions	Updates pinned Meteor package versions for the test app.
test-app/.meteor/release	Bumps test app Meteor release to `METEOR@3.4`.
test-app/.meteor/packages	Updates test app package pins to match the newer Meteor release.
site/package-lock.json	Updates site lockfile dependency graph (incl. lodash entry update).
packages/test-in-browser/server.js	Adds server-side autoupdate salt tweak to force reloads during browser testing.
packages/test-in-browser/README.md	Adds stub package README explaining temporary nature.
packages/test-in-browser/package.js	Introduces a stub `test-in-browser` package without jQuery.
packages/test-in-browser/driver.js	New jQuery-free browser test runner UI/logic.
packages/test-in-browser/driver.html	New Blaze templates for the browser test runner UI.
packages/test-in-browser/driver.css	New styling for the browser test runner UI.
packages/test-in-browser/.npm/package/README	Generated metadata for Meteor package npm deps.
packages/test-in-browser/.npm/package/npm-shrinkwrap.json	Locks npm deps for `test-in-browser` (bootstrap/diff).
packages/test-in-browser/.npm/package/.gitignore	Ignores `node_modules` for the package’s npm deps.
packages/test-in-browser/.gitignore	Ignores package build artifacts.
packages/spacebars-tests/templating_tests.js	Makes DOM interactions compatible with both jQuery and native DOM.
packages/spacebars-tests/template_tests.js	Removes/guards jQuery usage; adds native event triggering helpers; converts some tests to async.
packages/spacebars-tests/old_templates_tests.js	Mirrors template_tests backend-agnostic updates for legacy templates.
packages/spacebars-tests/package.js	Removes strong test dependency on `jquery` package.
packages/spacebars-tests/.versions	Removes `jquery` from pinned test package versions.
packages/observe-sequence/observe_sequence_tests.js	Converts multiple tests to `Tinytest.addAsync` and awaits shared helpers.
packages/blaze/render_tests.js	Updates tests to pass with or without jQuery-backed DOM backend.
packages/blaze/package.js	Makes jQuery a client-only weak dependency; removes strong dependency from Blaze’s tests.
packages/blaze/materializer.js	Adjusts promise/thenable handling in materialization flow.
packages/blaze/dombackend.js	Adds jQuery detection/logging; native parseHTML path; native delegation wrapper changes; native teardown hooks including `remove()` override.
packages/blaze/blaze.d.ts	Removes jquery import while still referencing `$` types.
packages/blaze/.versions	Removes `jquery` from pinned Blaze package versions.
.github/workflows/blaze-tests.yml	Adds a second CI job to run tests with `--extra-packages=jquery`.

Files not reviewed (2)

packages/test-in-browser/.npm/package/npm-shrinkwrap.json: Language not supported
site/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/test-in-browser/driver.css

packages/test-in-browser/driver.js

packages/blaze/dombackend.js

packages/test-in-browser/server.js

packages/test-in-browser/driver.html

.github/workflows/blaze-tests.yml

packages/blaze/materializer.js

packages/test-in-browser/driver.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jankapunkt · 2026-04-10T11:55:58Z

@dupontbertrand do you have some time to spare to take a look at this one?

dupontbertrand

Incoming..

packages/blaze/materializer.js

packages/test-in-browser/package.js

packages/spacebars-tests/template_tests.js

packages/spacebars-tests/old_templates_tests.js

packages/spacebars-tests/template_tests.js

jankapunkt · 2026-04-11T17:53:03Z

@dupontbertrand all comments are addressed in 6c20849 and 79a5299

dupontbertrand · 2026-04-11T23:10:43Z

packages/spacebars-tests/old_templates_tests.js

+      if (hasJquery) {
+        $(input).trigger('focus');
+      } else {
+        trigger({ el: input, eventName: 'focusin', bubbles: true });


It's eventName or eventType here ?

dupontbertrand · 2026-04-11T23:10:48Z

packages/spacebars-tests/old_templates_tests.js

+      if (hasJquery) {
+        $(input).trigger('blur');
+      } else {
+        trigger({ el: input, eventName: 'focusout', bubbles: true });


It's eventName or eventType here ?

dupontbertrand · 2026-04-11T23:10:51Z

packages/spacebars-tests/old_templates_tests.js

+      if (hasJquery) {
+        $(input).trigger('focus');
+      } else {
+        trigger({ el: input, eventName: 'focusin', bubbles: true });


It's eventName or eventType here ?

jankapunkt added 6 commits March 29, 2026 15:22

tests: update test-app to 3.4

7f1f234

tests: update npm deps to latest

1cd9cac

fix(blaze): explicitly catch and report exceptions in then(maybePromi…

3a9c783

…ses, fn)

fix(tests): move async tests to Tinytest.addAsync

ce83d37

tests: fully remove jquery from all tests and fix delegation

470ef7c

tests: include jquery based on env flag in tests

1a43798

jankapunkt mentioned this pull request Mar 31, 2026

release 3.1.0 #492

Open

18 tasks

jankapunkt changed the title ~~Tests/jquery~~ Tests: jquery + native DOM backends Mar 31, 2026

dependabot bot and others added 7 commits April 3, 2026 15:36

Merge remote-tracking branch 'origin' into tests/jquery

b9d0be4

Merge remote-tracking branch 'origin/release-3.1.0' into tests/jquery

c15a1de

packages: add modified test-in-browser package for on/off jQuery in t…

d0c18d1

…ests

tests: full dual mode support (jquery on/off) for local browser-based…

a559d9d

… tests

ci: run tests with and without jquery

48de9aa

tests: full jquery on/off compat via --extra-packages

8da1ef4

jankapunkt marked this pull request as ready for review April 8, 2026 07:54

jankapunkt requested review from Copilot and italojs April 8, 2026 07:59

jankapunkt mentioned this pull request Apr 8, 2026

feat: dual-mode JQuery/native DOM backend #493

Merged

11 tasks

Copilot started reviewing on behalf of jankapunkt April 8, 2026 08:00 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

jankapunkt and others added 2 commits April 8, 2026 10:12

ci: correct typo in .github/workflows/blaze-tests.yml

cbe9280

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix(blaze): delegate teardown in HTMLElement.remove

731117d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jankapunkt added this to the 3.1 milestone Apr 8, 2026

jankapunkt mentioned this pull request Apr 9, 2026

packages: remove jQuery from test-in-browser meteor/meteor#14308

Open

jankapunkt added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code ready2review feel free to add your review to this PR labels Apr 9, 2026

Merge remote-tracking branch 'origin/release-3.1.0' into tests/jquery

5339ffa

jankapunkt requested a review from zodern April 10, 2026 11:57

dupontbertrand reviewed Apr 10, 2026

View reviewed changes

jankapunkt added 2 commits April 11, 2026 19:40

fix: address review comments

79a5299

fix: revert error handling in materializer

6c20849

jankapunkt requested a review from dupontbertrand April 11, 2026 17:53

dupontbertrand reviewed Apr 11, 2026

View reviewed changes

Uh oh!

Conversation

jankapunkt commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Findings form initial research

Uh oh!

jankapunkt commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Run dual mode in local browser tests:

Run dual mode in test-in-console

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jankapunkt commented Apr 10, 2026

Uh oh!

dupontbertrand left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jankapunkt commented Apr 11, 2026

Uh oh!

dupontbertrand Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

dupontbertrand Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

dupontbertrand Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jankapunkt commented Mar 31, 2026 •

edited

Loading

jankapunkt commented Apr 8, 2026 •

edited

Loading

Run dual mode in `test-in-console`

dupontbertrand left a comment •

edited

Loading