Skip to content

[Meteor 3 - Feature]: Meteor create uses git instead of vendorized#12697

Merged
Grubba27 merged 13 commits intorelease-3.0from
feature/meteor-create-git-url-sc-141
Jul 4, 2023
Merged

[Meteor 3 - Feature]: Meteor create uses git instead of vendorized#12697
Grubba27 merged 13 commits intorelease-3.0from
feature/meteor-create-git-url-sc-141

Conversation

@Grubba27
Copy link
Copy Markdown
Contributor

@Grubba27 Grubba27 commented Jun 28, 2023

Under devolvement and discussion.

There are a few open topics I'm open to suggestions.


Meteor create changes

Today, when we use meteor create <app> we use a static asset that is within the tool itself. In my proposal, I want to change how this works, there are a few reasons:

  • Ease of maintenance, if something is wrong with a starter it can be changed easily(now we will use git);
  • Possibility of adding new examples and being open to more options because we will be using the network;

Meteor create --example "exampleapp"

Would instead of just list and show how to clone, it would clone it and make it ready for your development.

Meteor create --from "https://github.com/meteor/skel-react"

Creates from a based URL, clones from that repo, and then initiates the project with the current meteor.

Cons?

  • It will require the end user to have git installed to do a git clone. I guess it falls into our philosophy of being easy to use but I'm not sure if this makes sense now;
  • I propose a breaking change along with an update to our tutorials, I would suggest removing the option for creating a prototype app(create with the insecure packages) it would continue to exist and people can opt-in. I think we(Core Meteor members) should be more opinative on a few things and this is one of them.

Todo

  • Missing repos:

  • create skel-apollo

  • create skel-full

  • create skel-solid

  • create skel-vue

  • create skel-bare

  • create skel-minimal

  • create skel-svelte

  • create skel-vue-2

  • create skel-blaze

  • create skel-tailwind

  • create skel-chakra-ui

  • create skel-react

  • create skel-typescript

  • Create CDN repository (live here, will have it in a git)

  • Update docs(new option and ask the user to have git installed)

Open topics

  • How to get a repo(other ways than git clone and rm .git?)
  • Remove insecure or have an easy way to add to a newly created project?
  • Relying on a CDN is nice but maybe we could keep older versions in the tool in case the developer is offline?

@shortcut-integration
Copy link
Copy Markdown

This pull request has been linked to Shortcut Story #141: Meteor create <GIT_URL>.

@StorytellerCZ StorytellerCZ added this to the Release 3.0 milestone Jun 29, 2023
@StorytellerCZ
Copy link
Copy Markdown
Collaborator

As much interesting as this is, I don't think this should be worked at least till after 3.0 is released.

@Grubba27
Copy link
Copy Markdown
Contributor Author

Probably will be launched together or a little bit later on, and IMO is an easy win for us in the team being able to change and update the skeletons and even add more without having to make a new whole release

@Grubba27 Grubba27 self-assigned this Jun 29, 2023
@Grubba27 Grubba27 marked this pull request as ready for review June 29, 2023 17:45
@github-actions github-actions bot temporarily deployed to pull request June 29, 2023 18:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 3, 2023 18:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 3, 2023 18:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 4, 2023 12:30 Inactive
@Grubba27 Grubba27 merged commit fd6f663 into release-3.0 Jul 4, 2023
@zodern zodern mentioned this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants