Skip to content

[Meteor 3] Removing broken methods in version 3#13030

Merged
denihs merged 6 commits intorelease-3.0from
remove-check-password
Feb 27, 2024
Merged

[Meteor 3] Removing broken methods in version 3#13030
denihs merged 6 commits intorelease-3.0from
remove-check-password

Conversation

@denihs
Copy link
Copy Markdown
Contributor

@denihs denihs commented Feb 26, 2024

Removing methods that use Promise.await to be sync. These won't work on version 3.

  • _checkPassword: Now _checkPasswordAsync
  • setPassword: Now setPasswordAsync
  • OAuth1Binding.call: Now OAuth1Binding.callAsync
  • Assets.getText: Now Assets.getTextAsync
  • Assets.getBinary: Now Assets.getBinaryAsync

Copy link
Copy Markdown
Contributor

@Grubba27 Grubba27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@denihs denihs changed the title Remove _checkPassword [Meteor 3] Remove _checkPassword Feb 26, 2024
@denihs denihs added this to the Release 3.0 milestone Feb 26, 2024
@denihs denihs changed the title [Meteor 3] Remove _checkPassword [Meteor 3] Removing broken methods in version 3 Feb 26, 2024
@denihs denihs merged commit f91a05f into release-3.0 Feb 27, 2024
@Grubba27 Grubba27 mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants