Fix auth sub sending ready twice on load#13247
Merged
leonardoventurini merged 17 commits intorelease-3.0.2from Jul 26, 2024
Merged
Fix auth sub sending ready twice on load#13247leonardoventurini merged 17 commits intorelease-3.0.2from
leonardoventurini merged 17 commits intorelease-3.0.2from
Conversation
This reverts commit 0934440.
leonardoventurini
changed the title
leonardoventurini
force-pushed
the
fix/double-ready-auth-issue
branch
from
19e45cb to
c04af84
Compare
| messages, | ||
| cleanup | ||
| } | ||
| }; No newline at end of file |
Member
There was a problem hiding this comment.
Love to see the helpers expanded with these 🚀
nachocodoner
approved these changes
Jul 26, 2024
denihs
approved these changes
Jul 26, 2024
fredmaiaarantes
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After we started queueing
_sendOutstandingMethodBlocksMessagestheloginmethod started to be called after themeteor.loginServiceConfigurationsub call, thus recreating it once the user is set and sending tworeadymessages which flagged the auth process as ready before it actually was.The only way we could solve it without causing a regression was by waiting until the Meteor client is connected to start the login service sub. Other subs will still be recreated but shouldn't cause any issues, until we figure a better approach.