Fix regression on recompile behavior#13810
Merged
nachocodoner merged 5 commits intorelease-3.3.1from Jul 1, 2025
Merged
Conversation
The way the uninstall commands are currently formatted, they run together into a single line, which could in some rare cases (i.e. there are files in the current directory named "sudo" or "rm") cause data loss. Reformatting fixes this issue.
✅ Deploy Preview for v3-meteor-api-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression in Meteor config recompile behavior.
When adding support for the modern option in Meteor 3.3, the config reader was changed and
nodeModules.recompilestopped being picked up. No existing tests covered this case.This update restores correct handling of both modern and nodeModules.recompile without errors.
Regression vs fix
Pending