Skip to content

Fix regression on recompile behavior#13810

Merged
nachocodoner merged 5 commits intorelease-3.3.1from
fix-recompile-behaviour
Jul 1, 2025
Merged

Fix regression on recompile behavior#13810
nachocodoner merged 5 commits intorelease-3.3.1from
fix-recompile-behaviour

Conversation

@nachocodoner
Copy link
Copy Markdown
Member

@nachocodoner nachocodoner commented Jun 24, 2025

This PR fixes a regression in Meteor config recompile behavior.

When adding support for the modern option in Meteor 3.3, the config reader was changed and nodeModules.recompile stopped being picked up. No existing tests covered this case.

This update restores correct handling of both modern and nodeModules.recompile without errors.

Regression vs fix

"meteor": {
    "mainModule": {
      "client": "ui/main.jsx",
      "server": "api/main.js"
    },
    "testModule":  "tests/main.js",
    "modern": true,
    "nodeModules": {
      "recompile": {
        "pdfjs-dist": true
      }
    }
  },

image

Pending

  • Add a regression test to verify nodeModules.recompile options in various configs
  • Verify how nodeModules.recompile behaves in SWC

atomicmattie and others added 2 commits June 23, 2025 20:15
The way the uninstall commands are currently formatted, they run together into a single line, which could in some rare cases (i.e. there are files in the current directory named "sudo" or "rm") cause data loss. Reformatting fixes this issue.
@netlify
Copy link
Copy Markdown

netlify bot commented Jun 24, 2025

Deploy Preview for v3-meteor-api-docs canceled.

Name Link
🔨 Latest commit be8968f
🔍 Latest deploy log https://app.netlify.com/projects/v3-meteor-api-docs/deploys/685cfd080ebbef0008bbd5f6

@nachocodoner nachocodoner marked this pull request as ready for review June 25, 2025 15:32
Copy link
Copy Markdown
Member

@italojs italojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to rebase release 3.3.1 with devel before the merge, this PR brings 7be740c commit

@StorytellerCZ StorytellerCZ modified the milestone: Release 3.3.1 Jun 26, 2025
@nachocodoner nachocodoner requested a review from italojs June 26, 2025 13:01
@nachocodoner nachocodoner merged commit 385b904 into release-3.3.1 Jul 1, 2025
10 of 12 checks passed
@nachocodoner nachocodoner deleted the fix-recompile-behaviour branch July 1, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants