Make tagged_with take keywords and reject unknown options

[igor-alexandrov]

Independent PR off master (#66 has landed, so the diff is just this change). Mergeable in any order relative to its siblings #75–#81.

The scope declared no keyword parameters, so every option arrived in a catch-all hash and a typo was silently swallowed:

Post.tagged_with(%w[ruby], anyy: true)   # ran as if nothing was passed

It now validates against the four options it accepts:

ArgumentError: Unknown tagged_with options [:anyy], expected [:any, :exclude, :join_operator, :on]

That also removes three lines of hand-rolled defaulting and the options.delete(:on) that made caller-hash mutation possible.

Backwards compatible

Ruby 3 does not convert a positional hash into keywords, so pure keywords would have broken any caller building an options hash:

options = { any: true }
Post.tagged_with(%w[ruby], options)   # would raise under pure keywords

The scope takes that hash explicitly and merges it, so both call styles work — and typos raise whichever style they arrive by. Tested, including that the caller's hash comes back unmutated.

What I did not fix, and why

The return if base.respond_to?(:tagged_with) guard silently skips defining the scope when the host model already has one, while the four generated column scopes call tagged_with unconditionally — so a host with an incompatible implementation gets four quietly broken scopes.

Both obvious fixes are worse than the problem: raising leaves a model that defines its own tagged_with unable to use the gem at all; dropping the guard silently overwrites the host's method. That is a judgement call about the gem's contract, so it belongs to the maintainers rather than being slipped in here.

103 runs, 247 assertions, 0 failures, 0 errors, 0 skips

🤖 Generated with Claude Code