Conversation
ferrighi
changed the title
Collaborator
|
why is this needed? |
Collaborator
Author
|
I see that the last commit didn't pass the test. There are some changes in the nc_to_mmd importing new modules, so I tried to fix them. |
Collaborator
|
But this PR is only for the dockerfile? I learned from Veronica that we should be careful with using too many libraries. Do you think it would be possible to avoid any of them? |
Collaborator
|
aha - so nc_to_mmd in the py-mmd-tools package? Then, the change should be there shouldn't it? Maybe we need to talk.... |
mortenwh
approved these changes
Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.