Skip to content

update mmd-to-geonorge.xslt #177

Merged
ferrighi merged 2 commits intomasterfrom
issue_173
Apr 7, 2022
Merged

update mmd-to-geonorge.xslt #177
ferrighi merged 2 commits intomasterfrom
issue_173

Conversation

@ferrighi
Copy link
Collaborator

A series of changes to the mapping to geonorge inspire profile:

  • add parent support based on file name
  • add child support based on related_dataset
  • add schema in root (this helps external validation)
  • support for end_date missing
  • add Norwegian translation of Norwegian Meteorological Insitute
  • remove mapping of creation/revison from last_metadata_update. This was not
  • correct as the creation/revision refers to the dataset, not the metadata.

Closes #173
This update could also be tested in the catalogue ingestor from this current branch before merging to master.

@ferrighi ferrighi requested a review from TAlonglong December 10, 2021 11:31
@ferrighi ferrighi marked this pull request as ready for review December 10, 2021 11:34
Copy link
Collaborator

@mortenwh mortenwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @TAlonglong - can you also take a look?

Copy link
Collaborator

@TAlonglong TAlonglong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing commented line, else looks good to me.

@TAlonglong
Copy link
Collaborator

I forgot about this Lara.

Should I just merge? Or will you do this Lara?

remove commented line.
@ferrighi ferrighi merged commit 5b53ba0 into master Apr 7, 2022
@ferrighi
Copy link
Collaborator Author

ferrighi commented Apr 7, 2022

I've removed the commented out line.

@ferrighi ferrighi deleted the issue_173 branch April 7, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support for parent in mmd-to-geonorge.xsl

3 participants