Skip to content

Total Precipitable Water Plugin- EPPT 2571 #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpelley merged 9 commits into from
Oct 14, 2025
Merged

Total Precipitable Water Plugin- EPPT 2571 #2190

cpelley merged 9 commits into from
Oct 14, 2025

Conversation

@lambert-p
Copy link
Contributor

@lambert-p lambert-p commented Sep 8, 2025 •
edited
Loading

Addresses- EPPT-2571

Description

Create a plugin in IMPROVER to calculate precipitable water on pressure levels so it can be used it in the revised workflow design to calculate total precipitable water from the available StaGE data.

Plugin inputs: Humidity Mixing Ratio on pressure levels

Output: Precipitable water on pressure levels

Calculation:

The precipitable water on each pressure level is a function of the pressure difference across the vertical level and mean humidity mixing ratio in each level. We will assume that these values are represented by the input.

The pressure difference will be calculated from the linear mid-point between levels in Pascals. These values will form the bounds of the pressure coordinate on the output.

PW: Precipitable Water (m). q: Humidity mixing ratio (kg kg-1). ∆ p: Pressure difference (Pa == N m-2 == kg m-1 s-2). g: gravitational constant (9.91 m s-2). ρ: Water density constant (1000 kg m-3).

image

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

@lambert-p lambert-p added the EPP PR's related to Enhancing Post Processing team label Sep 8, 2025
@lambert-p lambert-p self-assigned this Sep 8, 2025
mo-philrelton
mo-philrelton requested changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@mo-philrelton mo-philrelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good and produces correct looking data, but there are a few code improvments I think you should make.

mo-philrelton
mo-philrelton requested changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@mo-philrelton mo-philrelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes. I just have a couple more suggestions for you

@lambert-p
Copy link
Contributor Author

lambert-p commented Sep 18, 2025

thank you for the comments @mo-philrelton I have made these changes.

mo-philrelton
mo-philrelton previously approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@mo-philrelton mo-philrelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

MoseleyS
MoseleyS requested changes Sep 22, 2025
View reviewed changes
Copy link
Member

@MoseleyS MoseleyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Phoebe. As discussed, there are a few things that I think could be simplified in this code which will make maintaining it in the future easier.

I also expected to see one or more unit tests testing that the inputs and outputs have specific data values, to help us catch unexpected consequences of future changes. Please can you add these.

@lambert-p
Copy link
Contributor Author

lambert-p commented Sep 25, 2025

The plugin has been run in the workflow and succeeded. I have chosen a cube from this output and plotted it below:

image

mo-robert-purvis
mo-robert-purvis previously approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@mo-robert-purvis mo-robert-purvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin interface works as expected - used in EPP workflow for TPW. The resulting cube is successfully manipulated for creating summed TPW. Tests look good.

MoseleyS
MoseleyS requested changes Sep 29, 2025
View reviewed changes
Copy link
Member

@MoseleyS MoseleyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Phoebe. This is doing the right thing. My suggestions are now around making the code easier to understand.

@lambert-p
Copy link
Contributor Author

lambert-p commented Oct 6, 2025

Thank you for the review @MoseleyS I have made the suggested changes.

MoseleyS
MoseleyS previously approved these changes Oct 7, 2025
View reviewed changes
Copy link
Member

@MoseleyS MoseleyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass (on a branch simulating merging this PR into master).

Anzerkhan27
Anzerkhan27 previously approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@Anzerkhan27 Anzerkhan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests verify the logic, units, and metadata.

@Anzerkhan27 Anzerkhan27 dismissed stale reviews from MoseleyS and themself via 6018cde October 14, 2025 10:26
MoseleyS
MoseleyS approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@MoseleyS MoseleyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving.

I have checked with Ben A and Carwyn P and we can safely ignore the missing codecov tests.

@cpelley cpelley merged commit 45c1097 into master Oct 14, 2025
5 checks passed
@cpelley
Copy link
Contributor

cpelley commented Oct 14, 2025

Bypassed rules in this case due to issues with the codecov currently.

@MoseleyS MoseleyS deleted the total_precipitable_water branch October 14, 2025 11:47
@gavinevans gavinevans mentioned this pull request Oct 14, 2025
Merged
2 tasks
gavinevans added a commit to gavinevans/improver that referenced this pull request Oct 14, 2025
@gavinevans
Merge remote-tracking branch 'upstream/master' into mobt_932_filtering
7a58a10 
* upstream/master:
  Alter site filtering for site EMOS (metoppv#2201)
  Remove Anzer's name due to git merging behaviour. (metoppv#2212)
  Total Precipitable Water Plugin- EPPT 2571  (metoppv#2190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoseleyS MoseleyS MoseleyS approved these changes

@mo-robert-purvis mo-robert-purvis mo-robert-purvis approved these changes

@Anzerkhan27 Anzerkhan27 Anzerkhan27 left review comments

@mo-philrelton mo-philrelton mo-philrelton left review comments

Assignees

@lambert-p lambert-p

Labels

EPP PR's related to Enhancing Post Processing team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lambert-p @cpelley @MoseleyS @Anzerkhan27 @mo-robert-purvis @mo-philrelton