Alter site filtering for site EMOS #2201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hs and additional predictors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2201 +/- ##
==========================================
- Coverage 98.39% 95.45% -2.95%
==========================================
Files 124 147 +23
Lines 12212 14753 +2541
==========================================
+ Hits 12016 14082 +2066
- Misses 196 671 +475 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brhooper
requested changes
Oct 10, 2025
Contributor
brhooper
left a comment
brhooper
left a comment
There was a problem hiding this comment.
Thanks @gavinevans. I think that this code should allow us to filter down the sites used to train EMOS as we want to. I've added some minor comments.
…tering * upstream/master: Minor correction to write the output file from the test_gam_at_sites acceptance test to a temporary location, as usual. (metoppv#2204) Adds option for a landmask ancillary to be passed into the CLI (metoppv#2202) Mobt775 Add SAMOS apply plugins and all CLIs (metoppv#2153) Recursive filter mask zeros modifications (metoppv#2199) Correct passing through of variables for QRF application (metoppv#2196)
brhooper
requested changes
Oct 13, 2025
Contributor
brhooper
left a comment
brhooper
left a comment
There was a problem hiding this comment.
Thanks for making these changes @gavinevans. I've added one tiny comment.
…tering * upstream/master: Re-add lost unit it tests. (metoppv#2207)
…iple predictors provided
Handle situation where no sites overlap, test it, and test where mult…
maxwhitemet
approved these changes
Oct 14, 2025
Contributor
maxwhitemet
left a comment
maxwhitemet
left a comment
There was a problem hiding this comment.
Happy with the changes made. Approved 👍
gavinevans
added a commit
to gavinevans/improver
that referenced
this pull request
Oct 14, 2025
* upstream/master: Alter site filtering for site EMOS (metoppv#2201) Remove Anzer's name due to git merging behaviour. (metoppv#2212) Total Precipitable Water Plugin- EPPT 2571 (metoppv#2190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/metoppv/mo-blue-team/issues/980
Description
This PR alters the site filtering used by site EMOS, so that it uses the set of common sites across the forecasts, truths and additional predictors when training site EMOS, when an additional predictor is provided.
Testing: