docs(web): widen the Help line #478 narrowed, now that it is true (#479) - #495
Merged
Conversation
#478 narrowed "a message about something that failed appears where the work is" to just "a failed save explains itself inside the form" — CustomersPage's background balance-load failure landed inside its own New customer dialog at the time, the exact opposite of the wider claim, so Help couldn't promise app-wide what only Sales did. #479 (#489, #491) gave every dialog screen its own page/dialog split: FlocksPage, InventoryPage, ProductsPage, UsersPage, GradesPage, ExpensesPage, HistoryPage, DailyEntryPage, CustomersPage. Every screen with a <Dialog> now uses useDialogErrors — a background read can no longer land inside an open form, and dismissing a form drops only its own message. The wider claim is true app-wide now, so this restores #478's original wording verbatim (en/es/tl) rather than writing new copy — it was already reviewed and correct, just early. No GLOSSARY.md change: same reasoning #478 recorded — "error" is not a domain concept, nothing here renames or redefines one. Test reverts to the wide assertion from #477's original commit; the narrow #478 wording fails it, confirmed by mutation. 1644 web tests green, typecheck and build clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#478 narrowed the Help line "a message about something that failed appears where the work is" down to just "a failed save explains itself inside the form," because only Sales had the two-slot split at the time — CustomersPage's background balance-load failure landed inside its own New customer dialog, the exact opposite of the wider claim.
#479 (#489, #491) closed that gap: every dialog screen (Customers, Flocks, Inventory, Products, Users, Grades, Expenses, History, DailyEntry) now uses
useDialogErrors, so a background read can't land inside an open form and dismissing a form drops only its own message. The wider claim is true app-wide now.This restores #478's original wording verbatim (en/es/tl) — it was already written and reviewed correctly, just too early — rather than drafting new copy.
Verification
<Dialog>usesuseDialogErrorsbefore writing this (grepacrossweb/src/routes, all 11 screens).GLOSSARY.mdchange — same reasoning fix(web): give the sales dialogs their own error slot (#477) #478 recorded: "error" is not a domain concept, nothing here renames or redefines one.Closes #479.