Allow underscores in rig_name property. #558
Merged
miquelcampos merged 2 commits intomgear-dev:masterfrom Oct 12, 2025
Merged
Conversation
Done by changing its update method from `HelperSlots.updateLineEdit()` to `HelperSlots.updateLineEdit2`.
Member
|
@timothyliu3d thanks for the PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Please clearly state what you have changed and why you made these changes.
Allow underscores in
rig_nameproperty.Main guide settings tab now uses the
updateLineEdit2method, which ensures Maya-compatible names.This PR is because mGear currently prohibits the use of the underscore character when trying to specify a name for the rig root, which is a very common delimiter. It is possible to bypass this by editing the attributes directly; but having it accessible to users in an official capacity via the GUI is preferred.
There is another commit: some minor fixes to incorrect type hints without introducing new imports.
Testing Done
Please describe the tests that you ran to verify your changes.
Tested with:
Able to build a rig with rig root named "my_rig_root_with_underscores".
Custom step instance's
.mgear_run.modelproperty returns "my_rig_root_with_underscores" as expected.Guide template "EPIC Mannequin Template, Y-up" seems to build correctly.
Have not tested with other tools in suite.
Related Issue(s)
Please link the related issues.
N/A.