Skip to content

Allow underscores in rig_name property. #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miquelcampos merged 2 commits into from
Oct 12, 2025
Merged

Allow underscores in rig_name property. #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
590df8b
fix: Allow Maya-compatible names for `rig_name` property.
timothyliu3d Jul 11, 2025
65f4247
fix: Fix incorrect typehint.
timothyliu3d Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions release/scripts/mgear/core/curve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,11 @@ def addCurve(
Arguments:
parent (dagNode): Parent object.
name (str): Name
points (list of float): points of the curve in a one dimension array
points (list of float | list of datatypes.Vector | list of om2.MPoint):
points of the curve in a one dimension array
[point0X, point0Y, point0Z, 1, point1X, point1Y, point1Z, 1, ...].
close (bool): True to close the curve.
degree (bool): 1 for linear curve, 3 for Cubic.
degree (int): 1 for linear curve, 3 for Cubic.
m (matrix): Global transform.
op (bool, optional): If True will add a curve that pass over the points
This is equivalent of using"editPoint " flag
Expand Down
2 changes: 1 addition & 1 deletion release/scripts/mgear/shifter/guide.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1851,7 +1851,7 @@ def create_connections(self):
# Setting Tab
tap = self.guideSettingsTab
tap.rigName_lineEdit.editingFinished.connect(
partial(self.updateLineEdit, tap.rigName_lineEdit, "rig_name")
partial(self.updateLineEdit2, tap.rigName_lineEdit, "rig_name")
)
tap.mode_comboBox.currentIndexChanged.connect(
partial(self.updateComboBox, tap.mode_comboBox, "mode")
Expand Down